Image Toolkit Plugin

[DudeThatsErin]

I am submitting a new Community Plugin

• I attest that I have done my best to deliver a high-quality plugin, am proud of the code I have written, and would recommend it to others. I commit to maintaining the plugin and being responsive to bug reports. If I am no longer able to maintain it, I will make reasonable efforts to find a successor maintainer or withdraw the plugin from the directory.

Repo URL

Link to my plugin: https://github.com/DudeThatsErin/obsidian-image-toolkit

Release Checklist

• I have tested the plugin on
  • Windows
  • macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
• My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
  • main.js
  • manifest.json
  • styles.css (optional)
• GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• The id in my manifest.json matches the id in the community-plugins.json file.
• My README.md describes the plugin's purpose and provides clear usage instructions.
• I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
• I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
• I have added a license in the LICENSE file.
• My project respects and is compatible with the original license of any code from other plugins that I'm using.
• I have given proper attribution to these other projects in my README.md.

[claremacrae]

I would suggest that it is better to edit this change so that the existing entry remains in place, so that it is clear that the only differences are the ownership.

That is how past changes in ownership have been made.

[claremacrae]

The error checking may grumble that you are not editing the last entry but you can ignore that, if it happens.

[claremacrae]

Or you put is another way, you aren’t submitting a new plugin, you are taking over an existing one….

[DudeThatsErin]

Yeah, I was looking for the docs on how to do that but I couldn't find anything. So, do I just edit the line where the previous maintainer's name was and put my own?

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin ID mismatch, the ID in this PR (filecreator) is not the same as the one in your repo (file-creator). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
❌ Plugin name mismatch, the name in this PR (FileCreator) is not the same as the one in your repo (File Creator). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.
❌ Unable to find a release with the tag 1.2.2. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[claremacrae]

Yeah, I was looking for the docs on how to do that but I couldn't find anything. So, do I just edit the line where the previous maintainer's name was and put my own?

Yes, and make sure that that is the only difference in the file.

[DudeThatsErin]

Hm.... Changes can be cleanly merged but the validation failed?

I messed up with which version of the community-plugins.json I copied previously (hence the rogue plugin at the bottom - still a PR I am waiting for review) but I have fixed that and yet still validation failed. I guess I am still waiting for more checks?

[claremacrae]

The diff looks good.

The Obsidian team may have a suggestion about the wording of the author field here and in your fork - like how to make it clear that you are maintaining it but to give credit to the original author too.

I don’t know what their policy is.

But what you have currently looks like it’s the minimum viable diff.

[claremacrae]

Unfortunately your fork of the repo has not pulled in all the existing issues and pull requests.

I don’t know if it is possible to do that, but it would really help if it were possible.

I would suggest asking on #plugin-dev for advice on what you need to do to take over an existing plugin.

[claremacrae]

I suspect, from a Google search, that retaining issues and pull requests is only possible if ownership of the previous repo is transferred.

[DudeThatsErin]

It appears there is a way to download all existing issues and move them create new ones on my repo - So I will do that and link between them at the old repo.

[joethei]

Sorry, but given your track record with maintaining Obsidian related things we are not comfortable giving you ownership of this plugin.
I have forked the plugin over to the obsidian-community organization, and I am fixing up the plugin so it complies with our guidelines.
After that is processed and the plugin update has rolled out, I can give you maintainer access if you want though.

Sorry about that!