Add theme: Osaka Jade

.github/PULL_REQUEST_TEMPLATE/plugin.md

@@ -1,5 +1,7 @@
 # I am submitting a new Community Plugin
 
+- [ ] I attest that I have done my best to deliver a high-quality plugin, am proud of the code I have written, and would recommend it to others. I commit to maintaining the plugin and being responsive to bug reports. If I am no longer able to maintain it, I will make reasonable efforts to find a successor maintainer or withdraw the plugin from the directory.
+
 ## Repo URL
 
 <!--- Paste a link to your repo here for easy access -->

.github/workflows/format.yml

@@ -0,0 +1,24 @@
+name: Format
+on:
+  push:
+    branches:
+      - master
+jobs:
+  format:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          ref: ${{ github.head_ref }}
+      - uses: actions/setup-node@v3
+        with:
+          node-version: "16.x"
+      - run: npm ci --no-save
+      - run: npm run format
+      - name: Commit changes
+        run: |
+          git config --local user.name 'Obsidian Bot'
+          git config --local user.email '[email protected]'
+          git add .
+          git commit -m "chore: Format JSON" || exit 0
+          git push

.github/workflows/skip.yml

@@ -15,9 +15,9 @@ jobs:
           GH_REPO: ${{ github.repository }}
           NUMBER: ${{ github.event.issue.number }}
           LABELS: Skipped code scan
-      - run: gh issue edit "$NUMBER" --add-assignee "$ASSIGNEE"
+      - run: gh issue edit "$NUMBER" --remove-assignee "$ASSIGNEE"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           GH_REPO: ${{ github.repository }}
           NUMBER: ${{ github.event.issue.number }}
-          ASSIGNEE: joethei
+          ASSIGNEE: ObsidianReviewBot

.github/workflows/stale-validation-failed.yml

@@ -0,0 +1,22 @@
+name: 'Close stale PRs with failed validation'
+on:
+  schedule:
+    - cron: "27 3 * * *"
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+      actions: write
+    steps:
+      - uses: actions/stale@v9
+        with:
+          stale-pr-message: "Hi there, as this PR has not seen any activity in the last 7 days, it will be closed in 7 days unless there are any updates."
+          close-pr-message: "Hi there, to keep things tidy, we're closing PRs that haven't passed the validation after 14 days of inactivity."
+          days-before-stale: 7
+          days-before-close: 7
+          stale-pr-label: stale
+          only-pr-labels: Validation failed
+          operations-per-run: 200
+

.github/workflows/stale.yml

@@ -12,7 +12,7 @@ jobs:
     steps:
       - uses: actions/stale@v9
         with:
-          stale-pr-message: "Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates."
+          stale-pr-message: "Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.\nPlease double check that you have made all of the requested changes if you believe that this is a mistake."
           close-pr-message: "Hi there, to keep things tidy, we're closing PRs after one and a half months of inactivity.\nFeel free to create a new pull request when you're ready to continue. Thanks for your understanding!"
           days-before-stale: 30
           days-before-close: 15

.github/workflows/validate-plugin-entry.yml

@@ -49,8 +49,19 @@ jobs:
                 addWarning('Maintainers of this repo should be allowed to edit this pull request. This speeds up the approval process.');
               }
 
-              if (!context.payload.pull_request.body.includes('I have added a license in the LICENSE file.')) {
-                addError('You did not follow the pull request template');
+              const templateStrings = [
+                'I have tested the plugin on',
+                'My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)', 'GitHub release name matches the exact version number specified in my manifest.json',
+                'The `id` in my `manifest.json` matches the `id` in the `community-plugins.json` file.',
+                'My README.md describes the plugin\'s purpose and provides clear usage instructions.',
+                'I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins\'s adherence to these policies.',
+                'I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls',
+                'I have added a license in the LICENSE file.',
+                'My project respects and is compatible with the original license of any code from other plugins that I\'m using.',
+                'I have given proper attribution to these other projects in my `README.md`.'
+              ];
+              if (!templateStrings.every(element => context.payload.pull_request.body?.includes(element))) {
+                addError('You did not follow the pull request template. The PR template can be found [here](https://raw.githubusercontent.com/obsidianmd/obsidian-releases/refs/heads/master/.github/PULL_REQUEST_TEMPLATE/plugin.md)');
               }
 
               let plugins = [];
@@ -105,55 +116,55 @@ jobs:
                 addError(`It seems like you made a typo in the repository field \`${plugin.repo}\`.`);
               }
 
-              if (plugin.id.toLowerCase().includes('obsidian')) {
+              if (plugin.id?.toLowerCase().includes('obsidian')) {
                 addError(`Please don't use the word \`obsidian\` in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.`);
               }
-              if (plugin.id.toLowerCase().endsWith('plugin')) {
+              if (plugin.id?.toLowerCase().endsWith('plugin')) {
                 addError(`Please don't use the word \`plugin\` in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.`);
               }
-              if (!/^[a-z0-9-_]+$/.test(plugin.id)) {
+              if (plugin.id && !/^[a-z0-9-_]+$/.test(plugin.id)) {
                 addError('The plugin ID is not valid. Only alphanumeric lowercase characters and dashes are allowed.');
               }
 
-              else if (plugin.name.toLowerCase().includes('obsidian')) {
+              else if (plugin.name?.toLowerCase().includes('obsidian')) {
                 addError(`Please don't use the word \`Obsidian\` in your plugin name since it's redundant and adds clutter to the plugin list.`);
               }
-              if (plugin.name.toLowerCase().endsWith('plugin')) {
+              if (plugin.name?.toLowerCase().endsWith('plugin')) {
                 addError(`Please don't use the word \`Plugin\` in the plugin name since it's redundant and adds clutter to the plugin list.`);
               }
 
-              if (/^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\.[a-zA-Z0-9-.]+$/.test(plugin.author)) {
+              if (plugin.author && /^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\.[a-zA-Z0-9-.]+$/.test(plugin.author)) {
                 addWarning(`We generally discourage including your email addresses in the \`author\` field.`);
               }
 
-              if (plugin.description.toLowerCase().includes('obsidian')) {
+              if (plugin.description?.toLowerCase().includes('obsidian')) {
                 addError('Please don\'t include `Obsidian` in the plugin description');
               }
-              if (plugin.description.toLowerCase().includes('this plugin') || plugin.description.toLowerCase().includes('this is a plugin') || plugin.description.toLowerCase().includes('this plugin allows')) {
+              if (plugin.description?.toLowerCase().includes('this plugin') || plugin.description?.toLowerCase().includes('this is a plugin') || plugin.description?.toLowerCase().includes('this plugin allows')) {
                 addWarning('Avoid including sentences like `This is a plugin that does` in your description');
               }
 
-              if (plugin.description.length > 250) {
+              if (plugin.description?.length > 250) {
                 addError(`Your plugin has a long description. Users typically find it difficult to read a very long description, so you should keep it short and concise.`);
               }
 
-              if (plugins.filter(p => p.id === plugin.id).length > 1) {
+              if (plugin.id && plugins.filter(p => p.id === plugin.id).length > 1) {
                 addError(`There is already a plugin with the id \`${plugin.id}\`.`);
               }
-              if (plugins.filter(p => p.name === plugin.name).length > 1) {
+              if (plugin.name && plugins.filter(p => p.name === plugin.name).length > 1) {
                 addError(`There is already a plugin with the name \`${plugin.name}\`.`);
               }
-              if (plugins.filter(p => p.repo === plugin.repo).length > 1) {
+              if (plugin.repo && plugins.filter(p => p.repo === plugin.repo).length > 1) {
                 addError(`There is already a entry pointing to the \`${plugin.repo}\` repository.`);
               }
 
               const removedPlugins = JSON.parse(fs.readFileSync('community-plugins-removed.json', 'utf8'));
 
-              if (removedPlugins.filter(p => p.id === plugin.id).length > 1) {
+              if (plugin.id && removedPlugins.filter(p => p.id === plugin.id).length > 1) {
                 addError(`Another plugin used to exist with the id \`${plugin.id}\`. To avoid issues for users that still have the old plugin installed using this plugin ID is not allowed`);
               }
 
-              if (removedPlugins.filter(p => p.name === plugin.name).length > 1) {
+              if (plugin.name && removedPlugins.filter(p => p.name === plugin.name).length > 1) {
                 addWarning(`Another plugin used to exist with the name \`${plugin.name}\`. To avoid confussion we recommend against using this name.`);
               }
 
@@ -178,10 +189,17 @@ jobs:
                   }
                 }
 
-                if (manifest.id !== plugin.id) {
+                let allowedManifestKeys = [...validManifestKeys, 'authorUrl', 'fundingUrl', 'helpUrl'];
+                for (let key of Object.keys(manifest)) {
+                  if (!allowedManifestKeys.includes(key)) {
+                    addError(`Your manifest has the invalid \`${key}\` property.`);
+                  }
+                }
+
+                if (plugin.name && manifest.id !== plugin.id) {
                   addError(`Plugin ID mismatch, the ID in this PR (\`${plugin.id}\`) is not the same as the one in your repo (\`${manifest.id}\`). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.`);
                 }
-                if (manifest.name !== plugin.name) {
+                if (plugin.name && manifest.name !== plugin.name) {
                   addError(`Plugin name mismatch, the name in this PR (\`${plugin.name}\`) is not the same as the one in your repo (\`${manifest.name}\`). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.`);
                 }
 
@@ -215,10 +233,10 @@ jobs:
 
                   const assets = release.data.assets || [];
                   if (!assets.find(p => p.name === 'main.js')) {
-                    addError('Your latest Release is missing the `main.js` file.');
+                    addError('Your latest release is missing the `main.js` file.');
                   }
                   if (!assets.find(p => p.name === 'manifest.json')) {
-                    addError('Your latest Release is missing the `manifest.json` file.');
+                    addError('Your latest release is missing the `manifest.json` file.');
                   }
                 } catch (e) {
                   addError(`Unable to find a release with the tag \`${manifest.version}\`. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.`);
@@ -229,7 +247,7 @@ jobs:
               try {
                 await github.rest.licenses.getForRepo({owner, repo});
               } catch (e) {
-                addWarning(`Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to <https://choosealicense.com/> to compare different open source licenses.`);
+                addError(`Your repository does not include a license. Go to <https://choosealicense.com/> to compare different open source licenses.`);
               }
             })();
 
@@ -271,12 +289,25 @@ jobs:
                 pull_number: context.issue.number,
                 title: `Add plugin: ${plugin.name}`
               });
-              await github.rest.issues.addAssignees({
+
+              const comments = github.rest.issues.listComments({
                 owner: context.repo.owner,
                 repo: context.repo.repo,
-                issue_number: context.issue.number,
-                assignees: 'ObsidianReviewBot'
+                issue_number: context.issue.number
+              });
+              const commentAuthors = [];
+              for (const comment in comments) {
+                commentAuthors.push(comment.user.login);
+              }
+
+              if (!commentAuthors.includes("ObsidianReviewBot")) {
+                await github.rest.issues.addAssignees({
+                  owner: context.repo.owner,
+                  repo: context.repo.repo,
+                  issue_number: context.issue.number,
+                  assignees: 'ObsidianReviewBot'
                 });
+              }
 
               if(!context.payload.pull_request.labels.filter(label => label.name === 'Changes requested').length > 0) {
                 labels.push("Ready for review");

.github/workflows/validate-theme-entry.yml

@@ -112,6 +112,9 @@ jobs:
                 if (theme.name.toLowerCase().includes('theme')) {
                     addError(`We discourage themes from including the word \`theme\` in their name since it's redundant and makes the theme selection screen harder to visually parse.`);
                 }
+                if (theme.name.match(/([^A-Za-z0-9_\- ]+)/g)) {
+                    addError('Your theme name contains invalid symbols, allowed are letters, digits, spaces, hyphens and underscores.');
+                }
 
                 if (/^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\.[a-zA-Z0-9-.]+$/.test(theme.author)) {
                     addWarning('We generally discourage from including email addresses in the `author` field.');

community-css-themes-removed.json

@@ -0,0 +1,91 @@
+[
+  {
+    "name": "Molecule",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/manassadasivuni/obsidian-molecule/issues/1"
+  },
+  {
+    "name": "Vileplume",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/hungsu/vileplume-obsidian/issues/11"
+  },
+  {
+    "name": "Agora",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/Seraaron/agora-obsidian-theme/issues/4"
+  },
+  {
+    "name": "Slytherin",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/MatheusZarkov/Obsidian-Slytherin/issues/3"
+  },
+  {
+    "name": "gummy",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/7368697661/gummy/issues/3"
+  },
+  {
+    "name": "Creature",
+    "reason": "Repository archived"
+  },
+  {
+    "name": "Big & Bold",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/Bluemoondragon07/obsidian-big-and-bold/issues/20"
+  },
+  {
+    "name": "🔔 Chime",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/Bluemoondragon07/chime-theme/issues/25"
+  },
+  {
+    "name": "Light & Bright",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/Bluemoondragon07/obsidian-light-and-bright-theme/issues/8"
+  },
+  {
+    "name": "WilcoxOne",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/MattWilcox/obsidian-wilcox-one/issues/3"
+  },
+  {
+    "name": "Christmas",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/deathau/obsidian-christmas-theme/issues/2"
+  },
+  {
+    "name": "Nebula",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/dlccyes/obsidian-nebula/issues/3"
+  },
+  {
+    "name": "Shiba Inu",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/faroukx/Obsidian-shiba-inu-theme/issues/11"
+  },
+  {
+    "name": "Sparkling Wisdom",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/learnerfvs/Sparkling-Wisdom-obsidian-theme-/issues/7"
+  },
+  {
+    "name": "Spectrum",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/wiktoriavh/Spectrum/issues/60"
+  },
+  {
+    "name": "Venom",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/fatiger92/obsidian_venom_theme/issues/4"
+  },
+  {
+    "name": "WiseLight",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/learnerfvs/WiseLight/issues/4"
+  },
+  {
+    "name": "Shiba Inu",
+    "reason": "Developer policies violation: Remote resources",
+    "issue": "https://github.com/faroukx/Obsidian-shiba-inu-theme/issues/11"
+  }
+]