Skip to content

Conversation

CubieProg
Copy link
Contributor

@CubieProg CubieProg commented Jul 10, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/CubieProg/Obsidian-Yandex-Tracker-Issue

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jul 11, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jul 12, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.
Please be aware that it might take a few weeks before your plugin is reviewed due to the high volume of submissions currently.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4][5][6][7][8][9][10][11][12][13]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jul 18, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jul 22, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.
Please be aware that it might take a few weeks before your plugin is reviewed due to the high volume of submissions currently.

@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.
Please be aware that it might take a few weeks before your plugin is reviewed due to the high volume of submissions currently.

@ObsidianReviewBot ObsidianReviewBot removed their assignment Aug 29, 2025
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.
Please be aware that it might take a few weeks before your plugin is reviewed due to the high volume of submissions currently.

@Zachatoo Zachatoo self-assigned this Sep 3, 2025
@Zachatoo
Copy link
Collaborator

Zachatoo commented Sep 3, 2025

manifest.json
You should be tracking changes to this file in git. Obsidian looks at the manifest.json file at the root of your repo on your default branch to determine which release to download. If this isn't being updated then users will never get updates to your plugin.

--cell-size: 50px;, .board {, .row {, .square {, .white {, .black {, .red-hihglight {, .blue-hihglight {, .green-hihglight {, .processor-gantt-margin-bottom {, .gantt-wrapper {, and others
Please update your classes and custom variables to be more specific to your plugin to avoid conflicts with other plugins.

style: margin-left: ${offset}%;
You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

this.markdownParser.unregisterProcessors()
This isn't necessary. Since you're using this.plugin.registerMarkdownCodeBlockProcessor to register the processors, Obsidian will unload them for you when your plugin is unloaded.

const auth_header = createEl('h1', { text: "Авторизация." })
For section headings in settings use:

new Setting(containerEl).setName('name here').setHeading();

"OAuth Token", 'Укажите ваш OAuth Token', 'Укажите Org ID вашей организации'
Use sentence case in UI


attr: { text: "test caption" },
This looks like test code, do you need it?

You have a lot of dependencies listed in your package.json that you don't appear to be using, can you please uninstall unused dependencies?

private rerender(full: boolean = false) {
This is a bit extreme for what you're trying to do, which is re-render your Markdown codeblock processors.
Please consider having your processors be classes that extend MarkdownRenderChild, calling ctx.addChild to have the MarkdownCodeblockProcessor manage loading and unloading renderers as it sees fit, and registering your yandex-tracker-issue:rerender event to your processor classes and re-render themselves when you receive an event.
Here is an example if it's helpful.

@Zachatoo Zachatoo added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants