Skip to content

Conversation

ckelsoe
Copy link

@ckelsoe ckelsoe commented Jun 29, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/ckelsoe/obsidian-shell-path-copy

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template. The PR template can be found here
❌ Could not parse community-plugins.json, invalid JSON. Bad control character in string literal in JSON at position 592936


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template. The PR template can be found here


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add plugin Shell Path Copy (shell-path-copy) Add plugin: Shell Path Copy Jun 29, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:


Optional

[1][2]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.

@ObsidianReviewBot ObsidianReviewBot removed their assignment Jun 30, 2025
@ckelsoe
Copy link
Author

ckelsoe commented Jun 30, 2025

The issue with casting has been addressed, and a new version has been released.

Copy link

github-actions bot commented Jul 1, 2025

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: okawak/discord_message_sender. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link
Author

@ckelsoe ckelsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand what is going on. My entry is in the list and others have added theirs after mine. Why do I need to approve theirs?

@ckelsoe
Copy link
Author

ckelsoe commented Jul 1, 2025

I need help. I have merged this multiple times. I even moved my entry to the last entry - still have conflicts. I do not know what to do to fix this. Please help.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3]:This class is only available on desktop, which means that this will throw errors on mobile (that's a problem since you have isDesktopOnly marked as false in your manifest.json file.

[1]:You should not cast this, instead use a instanceof check to make sure that it's actually the adapter you expect.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jul 2, 2025
@ckelsoe
Copy link
Author

ckelsoe commented Jul 2, 2025

The issues identified in the code review have been resolved in release 1.10.0:

Fixed Issues:

  • Mobile compatibility: Removed desktop-only FileSystemAdapter import to ensure
    cross-platform compatibility
  • Type safety: Replaced unsafe casting with proper runtime function existence checks
  • Import dependencies: Eliminated desktop-only class dependencies that could prevent mobile
    loading

Technical Changes:

  • Removed FileSystemAdapter from module imports to prevent potential mobile parsing issues
  • Added runtime function existence validation instead of constructor type checks
  • Implemented proper duck typing for cross-platform adapter compatibility
  • Updated TypeScript declarations to remove desktop-only class extensions

Clarification:
While the absolute path functionality was properly guarded and never executed on mobile, the
desktop-only import could potentially cause module loading issues. We've eliminated this dependency
entirely to ensure full cross-platform compatibility while maintaining all desktop functionality.

The plugin now has zero desktop-only dependencies at the module level. All changes are available in
the latest release: https://github.com/ckelsoe/obsidian-shell-path-copy/releases/tag/1.10.0

Please re-review when convenient. Thank you for the detailed feedback!

@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jul 2, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jul 2, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.
Please be aware that it might take a few weeks before your plugin is reviewed due to the high volume of submissions currently.

@joethei
Copy link
Collaborator

joethei commented Jul 29, 2025

@joethei joethei added the Minor changes requested PR can be merged after some final changes have been requested label Jul 29, 2025
@ckelsoe
Copy link
Author

ckelsoe commented Jul 29, 2025

The issues identified have been resolved.

Changes

  • Clean up settings tab to comply with Obsidian guidelines
  • Remove redundant plugin description from settings
  • Remove "Settings" heading (only use headings when there are multiple sections)
  • Move GitHub links to a subtle footer at the bottom
  • Settings now start directly with content

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Aug 4, 2025
ckelsoe added 2 commits August 8, 2025 20:49
Added shell-path-copy (Shell Path Copy) for review
Copy link

github-actions bot commented Aug 8, 2025

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.13.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ckelsoe
Copy link
Author

ckelsoe commented Aug 8, 2025

The issue "Unable to find a release with the tag 1.13.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release" has been resolved. The new release is 1.14.0, and the version should match end to end. Thank you.

Copy link

Hi there, as this PR has not seen any activity in the last 7 days, it will be closed in 7 days unless there are any updates.

@github-actions github-actions bot added the stale label Aug 16, 2025
@ckelsoe
Copy link
Author

ckelsoe commented Aug 16, 2025

  • Updated - release 1.13.0 is now available
  • Ready for review
  • Bumping for review

@github-actions github-actions bot removed the stale label Aug 17, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: shuxueshuxue/PackUp4AI. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ckelsoe
Copy link
Author

ckelsoe commented Aug 17, 2025

I have no idea what to do here. There are not clear instructions on what to do to resolve issues when others are adding to the json. I did not edit the file. all I did was fix my code in my repository and updated a comment.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:


Optional

[1][2][3][4]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.

@ObsidianReviewBot ObsidianReviewBot removed their assignment Aug 18, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:


Optional

[1][2][3][4]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.

@ObsidianReviewBot ObsidianReviewBot removed their assignment Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants