Skip to content

Conversation

RobertMeissner
Copy link

@RobertMeissner RobertMeissner commented Jun 26, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The authorUrl field in your manifest should not point to the GitHub repository of the plugin.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Lookbehinds are not supported in iOS versions before 16.4


Optional

[1][2][3]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jun 27, 2025
@RobertMeissner
Copy link
Author

Updated https://github.com/RobertMeissner/obsidian-long-sentence-highlighter/releases/tag/1.0.0 with required and optional solved.

@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jun 27, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jun 27, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.
Please be aware that it might take a few weeks before your plugin is reviewed due to the high volume of submissions currently.

@joethei
Copy link
Collaborator

joethei commented Jul 28, 2025


"use strict";
Remove the main.js file from the repo and add it to the .gitignore, release assets should not be mixed with source assets.

"main": "main.ts",, "js": "dist/main.js",
These are not valid manifest entries, remove them.

containerEl.createEl('h2', {text: 'Highlight Long Sentences Settings'});
Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.

.setName('Maximum Words'), .setName('Highlight Color'), name: 'Highlight Long Sentences',
Use sentence case in UI, product / brand names follow the casing set by the respective owner.

this.app.workspace.on('file-open', this.highlightCurrentView.bind(this));
Events need to be registered, so they can be properly unloaded when the plugin is disabled. https://docs.obsidian.md/Plugins/Events

const style = document.createElement('style');
This is never cleaned up

@joethei joethei self-assigned this Jul 28, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jul 28, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: blueheron786/obsidian-stats-plugin. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Pushed package to the end
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin name mismatch, the name in this PR (Long Sentence Highlighter) is not the same as the one in your repo (Long sentence highlighter). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@RobertMeissner
Copy link
Author

@joethei thank you so much for your feedback. However, and I deeply apologize for it, somehow, you landed on the deprecated old version of my plugin. I have checked all the repo URLs I could find and have currently no clue how that happened. I updated the url on top of this chat. Here just for convenience, too: https://github.com/RobertMeissner/obsidian-long-sentence-highlighter
All your proposals have been changed in this correct repository. I hope it finds your approval.

@RobertMeissner RobertMeissner changed the title Add plugin: Long Sentence Highlighter Add plugin: Long sentence highlighter Jul 29, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin name mismatch, the name in this PR (Long Sentence Highlighter) is not the same as the one in your repo (Long sentence highlighter). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.
Please double check that you have made all of the requested changes if you believe that this is a mistake.

@github-actions github-actions bot added the stale label Aug 29, 2025
@github-actions github-actions bot removed the stale label Aug 29, 2025
@joethei
Copy link
Collaborator

joethei commented Aug 29, 2025

Oops,

name: 'Toggle long sentence highlighting',
This can just be Toggle, since Obsidian will prefix it with the plugin name when displayed.

@RobertMeissner
Copy link
Author

@joethei thank you for your reply. I shortened the command names and updated the release. I hope everything is now as it should be.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Aug 31, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Sep 1, 2025
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.
Please be aware that it might take a few weeks before your plugin is reviewed due to the high volume of submissions currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants