-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add plugin: Co-Intelligence AI #6690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hello!I found the following issues in your plugin submission Errors: ❌ It seems like you made a typo in the repository field This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ It seems like you made a typo in the repository field This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ It seems like you made a typo in the repository field This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ Your manifest does not have the required This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Updated manifest.json |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2][3][4][5][6][7]:You should not cast this, instead use a [1][2]:Using [1][2][3]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. Optional[1][2][3][4][5][6][7][8][9][10][11][12][13]:Casting to Do NOT open a new PR for re-validation. |
/skip The instances of assigning styles via Javascript are necessary for dynamically positioning a menu relative to a button. Other required changes have been addressed. |
Note: there is a PR here with non-JS menu positioning and screen recordings showing why I'm not using that solution: |
"main": "main.js", .workspace-tab-container { const currentNoteContent = await app.vault.cachedRead(note); function getAllTags(cache: CachedMetadata | null): string[] { export function debounce<TArgs extends readonly unknown[]>( plugin, and for the menu positioning, can't you use the existing Menu API? |
Thanks for this. I wasn't aware of the Menu API---I'll give that a try. |
Regarding the menu positioning, I investigated the Menu API, and unless I'm missing something (very possible!), I don't think it's suitable for my purposes. I have a screenshot below of the menu in question. It's currently implemented as a SolidJS component. ![]() FWIW I do have a css-only implementation in this PR: Epistemic-Technology/co-intelligence#2 , but the keyboard navigation in this version is really poor. It's more accessible and user friendly in my opinion to use the current method. There is a PR here showing the changes I made: https://github.com/Epistemic-Technology/co-intelligence/pull/4/files (It's cluttered with test files that can be ignored.) |
I have switched the context menu to use the native Obsidian Menu component. |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2][3]:You should not cast this, instead use a Optional[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more :Casting to Do NOT open a new PR for re-validation. |
Changes requested by bot have been made, ready for additional review by human. |
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/Epistemic-Technology/co-intelligence
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.