Skip to content

Add plugin: Web Viewer Bookmarks#5670

Closed
stefandanzl wants to merge 9 commits intoobsidianmd:masterfrom
danzl-it:master
Closed

Add plugin: Web Viewer Bookmarks#5670
stefandanzl wants to merge 9 commits intoobsidianmd:masterfrom
danzl-it:master

Conversation

@stefandanzl
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/stefandanzl/webviewer-bookmarks

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Web Viewer Bookmarks Add plugin: Web Viewer Bookmarks Mar 11, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Mar 12, 2025
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@github-actions
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Expected ',' or ']' after array element in JSON at position 581247


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@bnchiang96
Copy link
Contributor

Closing this PR in favor of a new submission with version 1.1.0, which addresses styling feedback by moving styles to styles.css and includes bug fixes for the modal.

@bnchiang96 bnchiang96 mentioned this pull request Mar 16, 2025
17 tasks
@stefandanzl
Copy link
Contributor Author

stefandanzl commented Mar 16, 2025

Closing this PR in favor of a new submission with version 1.1.0, which addresses styling feedback by moving styles to styles.css and includes bug fixes for the modal.

I think you mistakenly commented on my PR instead of your's?

@joethei joethei assigned joethei and unassigned ObsidianReviewBot Mar 20, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Mar 20, 2025
@stefandanzl
Copy link
Contributor Author

This plugin is not to bookmark markdown files but website urls as ribbon icons and commands and as far as I can tell there is neither a core plugin or functionality nor a community plugin available for this.

I changed the first heading of Readme.md and added the mention of "community plugin" to further clarify the inofficial nature.

I changed all the settings strings to follow the sentence case style.

I removed the heading in the settings page.

@stefandanzl
Copy link
Contributor Author

Do I have to edit obsidian-releases.json again or will this be done automatically?

I published a new release with the changes

@github-actions
Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Apr 27, 2025
@github-actions github-actions bot removed the stale label Apr 27, 2025
@stefandanzl
Copy link
Contributor Author

Hello, this plugin still needs approval, please let me know what to change or merge it.

@github-actions
Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label May 28, 2025
@Moyf
Copy link
Contributor

Moyf commented Jun 4, 2025

Why is this a plugin?
What's wrong with the default bookmarks plugin?

I think this plugin is useful because the native Bookmark plugin doesn't seem to allow customization of "open internally" and "open externally."

Normally, I prefer to open web links in an external browser, so I disabled this option in WebViewer:
image

However, for pages saved in bookmarks, I want them to open within WebViewer—currently, it seems the native Bookmark can't fulfill this requirement. (Or can it?)

@Moyf
Copy link
Contributor

Moyf commented Jun 4, 2025

Hello, this plugin still needs approval, please let me know what to change or merge it.

I think the bot will regularly scan each line of the code content mentioned in the review, and only after all of them have been modified will it automatically add or change Labels.
And it seems there's a command to skip the scanning and have a human review it again.

I feel a bit regretful—there doesn’t seem to be any documentation explaining the "bot/human review process" (or maybe I just couldn’t find it). I’ve seen several plugin authors waiting for updates until their PR were marked as stale.

@github-actions github-actions bot removed the stale label Jun 4, 2025
@github-actions
Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants