Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Checkbox Button #5301

Closed
wants to merge 2 commits into from
Closed

Add plugin: Checkbox Button #5301

wants to merge 2 commits into from

Conversation

hmumm
Copy link

@hmumm hmumm commented Feb 3, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/hmumm/checkbox-button/releases/tag/1.0.0

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

github-actions bot commented Feb 3, 2025

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ Avoid including sentences like This is a plugin that does in your description


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add plugin Checkbox Button Add plugin: Checkbox Button Feb 3, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Feb 4, 2025
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@joethei
Copy link
Collaborator

joethei commented Feb 20, 2025

name: string = "'Add Checkbox'";, 'Add Checkbox'
Use sentence case in UI

Why is this plugin needed?
If you put the Core command "Cycle bullet checkbox" / "Toggle checkbox status" on the mobile toolbar, wouldn't that work the same / better (because the exact placement of the cursor is not important)

@joethei joethei self-assigned this Feb 20, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Feb 20, 2025
@hmumm
Copy link
Author

hmumm commented Feb 20, 2025

You are correct, I did not know that was an option.

Thanks for the assistance.

@hmumm hmumm closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants