Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Daily Routine #5295

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Add plugin: Daily Routine #5295

merged 1 commit into from
Feb 25, 2025

Conversation

sechan100
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/sechan100/daily-routine-2

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1]:You should not cast this, instead use a instanceof check to make sure that it's actually a file/folder.


Optional

[1]:Use app.fileManager.trashFile(file: TAbstractFile) instead, this will make sure that the file is deleted according to the users preferences.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Feb 3, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Feb 3, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@joethei
Copy link
Collaborator

joethei commented Feb 20, 2025

"authorEmail": "[email protected]",
These aren't valid fields in the manifest, remove them.

"minAppVersion": "0.15.0",
You are using newer API's, set this to the latest public build number to be on the safe side.

name: "Open Routine View",, "Toggle Mobile View",, title: "Res schedule Todo",, i.setTitle("Reschedule Todo To Tomorrow");, header='Todo Option', name="Show On Calendar", header="Add New Todo", name="Show On Calendar", placeholder="New Todo", title: "Delete Todo",, title: "Delete Group",, title: "Remove Group from this note",, header='Group Option', header="Create Group", header="Start New Routine", placeholder="New Routine", name="Show On Calendar", title: "Delete Routine",, header='Routine Option', name='Show On Calendar', item.setTitle("Add Todo");, item.setTitle("Add Group");, item.setTitle("Merge Notes");, No Tasks..,

Active Criteria
, Last Day of Month, title: "Create Routine Note",, .setName("Daily Routine Folder Path"), .setName("Start of Week"), .setName("Do Confirmation when Unchecking Task")
Use sentence case in UI

title: "Res schedule Todo",
Typo,

plugin().app.isMobile;, export const isMobile = () => plugin().app.isMobile;
Use the Platform class from Obsidian instead of accessing outdated internal API's.

// Credits go to Liam's Periodic Notes Plugin: https://github.com/liamcain/obsidian-periodic-notes
This class should no longer be used, implement a AbstractInputSuggest instead.

export const parseFrontmatter = (fileContent: string) => {
Use the CachedMetadata API instead of manually implementing frontmatter parsing.

moment.updateLocale('en', {
Please don't change any settings here, this has the potential to break other plugins.

@joethei joethei self-assigned this Feb 20, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Feb 20, 2025
@sechan100
Copy link
Contributor Author

@joethei Feedback appreciated. I've reviewed and fixed all the requested changes.

I thought I had checked for sentence case issues, but it seems there were more than I expected—sorry about that.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Feb 21, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.0.2. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@sechan100
Copy link
Contributor Author

sechan100 commented Feb 24, 2025

@joethei I released tag 1.0.2.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:


Optional

[1]:Use app.fileManager.trashFile(file: TAbstractFile) instead, this will make sure that the file is deleted according to the users preferences.


Do NOT open a new PR for re-validation.

@ObsidianReviewBot ObsidianReviewBot removed their assignment Feb 25, 2025
@joethei joethei merged commit b7586d1 into obsidianmd:master Feb 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants