Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme: Sei #5204

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Add theme: Sei #5204

merged 1 commit into from
Jan 28, 2025

Conversation

iwa
Copy link
Contributor

@iwa iwa commented Jan 20, 2025

I am submitting a new Community Theme

Repo URL

Link to my theme: https://github.com/iwa/Sei

Theme checklist

  • My repo contains all required files (please do not add them to this obsidian-releases repo).
    • manifest.json
    • theme.css
    • The screenshot file (16:9 aspect ratio, recommended size is 512px by 288px for fast loading).
  • I have indicated which modes (dark, light, or both) are compatible with my theme.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my theme's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Themes/App+themes/Theme+guidelines and have self-reviewed my theme to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other themes that I'm using. I have given proper attribution to these other themes in my README.md.

@github-actions github-actions bot changed the title Add Sei theme Add theme: Sei Jan 20, 2025
Copy link

Hello!

I found the following issues in your theme submission

Errors:

❌ Your repository does not include a theme.css file


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@iwa
Copy link
Contributor Author

iwa commented Jan 20, 2025

hello! just wanted to ask, which file does Obsidian pulls from the repo when downloading a theme, the theme.css from the main branch or the one from the latest release? would have to adapt my CI if it's the first option :)

@joethei
Copy link
Collaborator

joethei commented Jan 28, 2025

It depends, if there is a release matching the version in the manifest then it will download from the release, if there is no release then it will use the file from the repo.

@joethei joethei merged commit 95fc9d3 into obsidianmd:master Jan 28, 2025
1 check passed
@iwa iwa deleted the patch-1 branch January 28, 2025 09:26
@iwa
Copy link
Contributor Author

iwa commented Jan 28, 2025

okey i see, thanks for the explanations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants