OneNote: Improve reliability and enterprise account support#528
Open
gurusince88 wants to merge 1 commit intoobsidianmd:masterfrom
Open
OneNote: Improve reliability and enterprise account support#528gurusince88 wants to merge 1 commit intoobsidianmd:masterfrom
gurusince88 wants to merge 1 commit intoobsidianmd:masterfrom
Conversation
Addresses issues obsidianmd#440, obsidianmd#398, obsidianmd#390, obsidianmd#334, and obsidianmd#313. Changes: - Add notes.read.all OAuth scope for M365/SharePoint enterprise accounts - Improve error messages to show specific details (401/403/429/504) - Replace fixed 60s retry with exponential backoff and jitter - Switch from data.json to frontmatter-based import tracking (onenote-id) - Fix mobile portrait UI: ensure sign-in button is visible The frontmatter approach (similar to Notion API importer) fixes the issue where "Skip previously imported" would incorrectly skip pages that had been deleted from the vault. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the reliability of the OneNote importer, particularly for enterprise M365/SharePoint accounts.
Addresses: #440, #398, #390, #334, #313
Changes
notes.read.allfor M365/SharePoint enterprise accounts (fixes Importer for OneNote does not import anything #440, Importer Broken for OneNote - Limited how fast can be imported #334)data.jsontoonenote-idfrontmatter (like Notion API importer) to fix false "previously imported" skips (fixes Importer skipping items that are not previously imported #398)Test plan
Breaking changes
Notes imported after this change will have
onenote-idin their frontmatter. The olddata.jsontracking is no longer used, so users who previously imported notes will need to either: