Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade jsdom to avoid nwsapi #1332

Merged
merged 3 commits into from
May 13, 2024
Merged

downgrade jsdom to avoid nwsapi #1332

merged 3 commits into from
May 13, 2024

Conversation

mbostock
Copy link
Member

Fixes #1330. Supersedes #1331.

@mbostock mbostock requested review from Fil and mootari May 13, 2024 18:13
@mbostock
Copy link
Member Author

It’d probably be useful for us to run yarn upgrade and make sure we’re also testing against the latest dependencies… We were still running against nwsapi 2.2.7 which is why we didn’t notice the problem.

@Fil
Copy link
Contributor

Fil commented May 13, 2024

LGTM with a caveat: "^23.0.0" accepts both [email protected] and [email protected], which means we don't guarantee which CSS selector engine is used. To be clear, 23.2.0 is OK, but 23.1.0 is broken (tested broken) — and any previous version is probably broken too because they all use nwsapi.

So I think we'd be better off being explicit about "jsdom": "=23.2.0"?

@mbostock
Copy link
Member Author

I think we should do ^23.2.0 since that’s pretty standard and if they were to do a patch on 23.x it seems like they would keep the same non-broken selectors implementation.

@mbostock mbostock enabled auto-merge (squash) May 13, 2024 20:01
@mbostock mbostock merged commit f6d94d2 into main May 13, 2024
4 checks passed
@mbostock mbostock deleted the mbostock/downgrade-jsdom branch May 13, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants