Add support for Oasis Scan API v2 as a backend option for Wallet #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
force-pushed
the
mz/api-oasisscan2
branch
16 times, most recently
from
b63ee41
to
943af68
Compare
buberdds
force-pushed
the
mz/api-oasisscan2
branch
7 times, most recently
from
933dbce
to
a7cf45e
Compare
buberdds
force-pushed
the
mz/api-oasisscan2
branch
from
a7cf45e
to
cd9e2c2
Compare
buberdds
changed the title
buberdds
force-pushed
the
mz/api-oasisscan2
branch
from
cd9e2c2
to
39f0498
Compare
lukaw3d
approved these changes
Nov 12, 2024
| runtimeId: t.runtimeId, | ||
| round: t.round, | ||
| nonce: | ||
| t.ctx?.nonce ?? t.etx?.nonce != null ? BigInt(t.ctx?.nonce ?? t.etx?.nonce).toString() : undefined, |
There was a problem hiding this comment.
This looks odd. Add a comment if you are handling special cases - e,g. why does ctx.nonce not check != null but etx.nonce does
There was a problem hiding this comment.
I did not find any special cases in responses. was following v1 e9fdf1f3e, Will update if necessary in the follow up PR.
buberdds
force-pushed
the
mz/api-oasisscan2
branch
from
39f0498
to
52e8cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://api.oasisscan.com/v2/swagger/
Testing requires .env update
Notes:
fromaddress is oasis1 not eth address compared to v1 Address format diff between v1 and v2 bitcat365/oasisscan-backend#13TODOs:
runtimequery param will be added to V2transactionsendpoint in the future. At this point we cannot show ParaTime deposits or withdraws Not able fetch runtime transactions bitcat365/oasisscan-backend#8