-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switch to open source setupwizard lib #137
base: dev
Are you sure you want to change the base?
Conversation
Seems like it references a local module (but missing from this pull request). |
It has the same layout as deagle. I think I missed the Readme part. Fixed now. |
I'm planning to remove local repo dependency (deagle) in the future, for a simpler and developer-friendly build environment. Is there any advantage to replace AAR dependency with local repo dependency in this specific case? |
My purpose is to remove blob as much as possible. That's the advantage. There's a third-party setup wizard lib (https://github.com/Trumeet/Setupwizard) on maven cloned from Google's repo. I would hold no objection if you prefer the maven one. |
I recently realized that gradle supports git dependencies natively: https://blog.gradle.org/introducing-source-dependencies. Is that an acceptable option for you? |
Since the setupwizard library was extracted from Android's source code, it would be even closer to completely FOSS if we switch the setupwizard library to it's source code rather than keep it as a blob. Another advantage is that we use the lastest upstream code (which has more eye-candy).