Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch to open source setupwizard lib #137

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

proletarius101
Copy link

@proletarius101 proletarius101 commented Sep 1, 2020

Since the setupwizard library was extracted from Android's source code, it would be even closer to completely FOSS if we switch the setupwizard library to it's source code rather than keep it as a blob. Another advantage is that we use the lastest upstream code (which has more eye-candy).

@oasisfeng
Copy link
Owner

oasisfeng commented Sep 1, 2020

Seems like it references a local module (but missing from this pull request).
Does that open source lib have a published artifect (on JCenter or else)?

@proletarius101
Copy link
Author

It has the same layout as deagle. I think I missed the Readme part. Fixed now.
Unfortunately it's not hosted on any maven repo. Google only offer it inside the Android monorepo.

@oasisfeng
Copy link
Owner

I'm planning to remove local repo dependency (deagle) in the future, for a simpler and developer-friendly build environment.

Is there any advantage to replace AAR dependency with local repo dependency in this specific case?

@proletarius101
Copy link
Author

proletarius101 commented Sep 2, 2020

My purpose is to remove blob as much as possible. That's the advantage. There's a third-party setup wizard lib (https://github.com/Trumeet/Setupwizard) on maven cloned from Google's repo. I would hold no objection if you prefer the maven one.

@proletarius101
Copy link
Author

I recently realized that gradle supports git dependencies natively: https://blog.gradle.org/introducing-source-dependencies. Is that an acceptable option for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants