BasePhaseLoader: Allow parameters to be specified in 'options' blocks #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of 'inherit' type
This allows ECD blocks like:
- inherit: jdbc.sqlite.cse.phase
name: information-extractor
options: |
- inherit: phases.ie.fixedregex
regex: "\\$[^.]*"
i.e. specifying parameters inline in the options block rather than only
in the inherited ECDs.
|
This issue has been also touched upon in issue #17. |
|
No problem merging it, are there tests that validate these cases? |
elmer-garduno
added a commit
that referenced
this pull request
Jun 17, 2014
BasePhaseLoader: Allow parameters to be specified in 'options' blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows ECD blocks like:
'''
name: information-extractor
options: |
regex: "$[^.]*"
'''
i.e. specifying parameters inline in the options block rather than only
in the inherited ECDs.