core: added ability to alter video device through API #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2025
JasperB-TeamBlue
force-pushed
the
set-display-type-api
branch
from
ec5b5e3 to
47e90d4
Compare
Return an additional video_type field in the display info for a VM, Template or Instance. This next to the already existing graphic info and display type. This field was added to have a difference between the QXL/VNC and VGA/VNC for example. This exposes the chosen Video Type in the UI to the API side. This also opens up the possibility to alter the Video Type for existing VM's for example from VGA/VNC to QXL/VNC. Signed-off-by: Jasper Berton <[email protected]>
JasperB-TeamBlue
force-pushed
the
set-display-type-api
branch
from
47e90d4 to
6f58298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
When pulling info for a vm, template or instance type through the API return a video_type in the console info together with the graphic console as the type. Ability to alter the video device attached to a vm through the PUT api call. Saves this update as a configuration for the next run of the VM if it is in the up state.
Needs Updated Display class to contain a video type reference ovirt-engine-api-model#117 implemented in api model to properly function.
Are you the owner of the code you are sending in, or do you have permission of the owner?
[y]