everything #160
everything #160
Conversation
quickemu-project#725 Co-authored-by: Phil Clifford <[email protected]>
quickemu-project#735 Co-authored-by: Alejandro <[email protected]>
Added new configuration file option "sound_card" and new command-line switch "--sound-card" to change the virtual sound hardware. Allowed options are "intel-hda" (default), "ac97", "es1370", "sb16", and "none". Also changed default sound card for Solaris to "ac97" and for FreeDOS to "sb16". quickemu-project#705 Co-authored-by: Chase Covello <[email protected]>
quickemu-project#724 Co-authored-by: Phil Clifford <[email protected]>
Signed-off-by: zenobit <[email protected]>
Signed-off-by: zenobit <[email protected]>
Signed-off-by: zenobit <[email protected]>
Signed-off-by: zenobit <[email protected]>
Signed-off-by: zenobit <[email protected]>
Signed-off-by: zenobit <[email protected]>
Signed-off-by: zenobit <[email protected]>
list, list_csv and list_json Not mentioned! Signed-off-by: zenobit <[email protected]>
Signed-off-by: zenobit <[email protected]>
Signed-off-by: zenobit <[email protected]>
Signed-off-by: zenobit <[email protected]>
Signed-off-by: zenobit <[email protected]>
Signed-off-by: zenobit <[email protected]>
Co-authored-by: Liam <[email protected]>
Signed-off-by: zenobit <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1780,7 +1787,10 @@ if [ -n "${VM}" ] && [ -e "${VM}" ]; then | |||
| VMPATH=$(realpath "$(dirname "${VM}")") | |||
| VM_MONITOR_SOCKETPATH="${VMDIR}/${VMNAME}-monitor.socket" | |||
| VM_SERIAL_SOCKETPATH="${VMDIR}/${VMNAME}-serial.socket" | |||
|
|
|||
| if [ ! -f "${disk_img}" ]; then | |||
| cd "${VMPATH}" | |||
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck
quickget|1138 col 34| Double quote array expansions to avoid re-splitting elements. SC2068
quickget|1141 col 14| Double quote array expansions to avoid re-splitting elements. SC2068
quickget|1141 col 32| Double quote array expansions to avoid re-splitting elements. SC2068
quickget|1147 col 25| Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2207
quickget|1162 col 10| Double quote array expansions to avoid re-splitting elements. SC2068
quickget|1162 col 28| Double quote array expansions to avoid re-splitting elements. SC2068
quickget|1362 col 29| Quote this to prevent word splitting. SC2046
quickget|1362 col 52| Double quote to prevent globbing and word splitting. SC2086
quickget|1362 col 91| Double quote to prevent globbing and word splitting. SC2086
quickget|1635 col 24| Double quote to prevent globbing and word splitting. SC2086
quickget|1646 col 92| This { is literal. Check expression (missing ;/\n?) or quote it. SC1083
quickget|1646 col 106| This } is literal. Check expression (missing ;/\n?) or quote it. SC1083
quickget|1646 col 144| Double quote to prevent globbing and word splitting. SC2086
quickget|1646 col 152| Double quote to prevent globbing and word splitting. SC2086
quickget|1674 col 24| Double quote to prevent globbing and word splitting. SC2086
quickget|1676 col 24| Double quote to prevent globbing and word splitting. SC2086
quickget|1703 col 27| Double quote to prevent globbing and word splitting. SC2086
quickget|2256 col 9| read without -r will mangle backslashes. SC2162
quickget|2554 col 90| This { is literal. Check expression (missing ;/\n?) or quote it. SC1083
quickget|2554 col 104| This } is literal. Check expression (missing ;/\n?) or quote it. SC1083
quickget|2554 col 142| Double quote to prevent globbing and word splitting. SC2086
quickget|2554 col 150| Double quote to prevent globbing and word splitting. SC2086
quickget|2635 col 33| Double quote to prevent globbing and word splitting. SC2086
quickget|2737 col 19| Double quote to prevent globbing and word splitting. SC2086
quickget|2748 col 19| Double quote to prevent globbing and word splitting. SC2086
quickget|2749 col 20| Double quote to prevent globbing and word splitting. SC2086
quickget|2768 col 32| Double quote to prevent globbing and word splitting. SC2086
quickget|2769 col 25| Double quote to prevent globbing and word splitting. SC2086
quickget|2772 col 32| Double quote to prevent globbing and word splitting. SC2086
quickget|2773 col 25| Double quote to prevent globbing and word splitting. SC2086
quickget|2824 col 32| Double quote to prevent globbing and word splitting. SC2086
quickget|2825 col 25| Double quote to prevent globbing and word splitting. SC2086
quickget|2828 col 32| Double quote to prevent globbing and word splitting. SC2086
quickget|2829 col 25| Double quote to prevent globbing and word splitting. SC2086
quickget|3585 col 29| Quote this to prevent word splitting. SC2046
quickget|3591 col 34| Remove quotes from right-hand side of =~ to match as a regex rather than literally. SC2076
quickget|3593 col 29| Quote this to prevent word splitting. SC2046
quickget|3599 col 12| Expressions don't expand in single quotes, use double quotes for that. SC2016
quickget|3636 col 29| Quote this to prevent word splitting. SC2046
quickget|3651 col 36| Double quote to prevent globbing and word splitting. SC2086
quickget|3653 col 10| Double quote to prevent globbing and word splitting. SC2086
quickget|3655 col 17| Double quote to prevent globbing and word splitting. SC2086
quickget|3657 col 16| Double quote to prevent globbing and word splitting. SC2086
quickget|3659 col 31| Double quote to prevent globbing and word splitting. SC2086
quickget|3663 col 24| Double quote to prevent globbing and word splitting. SC2086
quickget|3667 col 17| Double quote to prevent globbing and word splitting. SC2086
quickget|3669 col 14| Double quote to prevent globbing and word splitting. SC2086
quickget|3714 col 10| Useless echo? Instead of 'echo $(cmd)', just use 'cmd'. SC2005
quickget|3714 col 48| Quote this to prevent word splitting. SC2046
quickget|3719 col 28| Double quote to prevent globbing and word splitting. SC2086
quickget|3722 col 33| Double quote to prevent globbing and word splitting. SC2086
quickget|3756 col 43| Remove quotes from right-hand side of =~ to match as a regex rather than literally. SC2076
quickget|3813 col 36| Remove quotes from right-hand side of =~ to match as a regex rather than literally. SC2076
quickget|3829 col 8| Quote this to prevent word splitting. SC2046
quickget|3829 col 19| Double quote to prevent globbing and word splitting. SC2086
quickget|3830 col 24| Double quote to prevent globbing and word splitting. SC2086
quickget|3862 col 37| Quote this to prevent word splitting. SC2046
quickget|3865 col 41| Quote this to prevent word splitting. SC2046
| local SIMPLE_NAME="" | ||
| local PRETTY_NAME="" | ||
| SIMPLE_NAME="${1}" | ||
| PRETTY_NAME=$(os_info ${SIMPLE_NAME} | cut -d'|' -f1) |
| local SIMPLE_NAME="" | ||
| local BASED="" | ||
| SIMPLE_NAME="${1}" | ||
| BASED=$(os_info ${SIMPLE_NAME} | cut -d'|' -f2) |
| local SIMPLE_NAME="" | ||
| local CREDE="" | ||
| SIMPLE_NAME="${1}" | ||
| CREDE=$(os_info ${SIMPLE_NAME} | cut -d'|' -f3) |
| local SIMPLE_NAME="" | ||
| local HOMEP="" | ||
| SIMPLE_NAME="${1}" | ||
| HOMEP=$(os_info ${SIMPLE_NAME} | cut -d'|' -f4) |
| local SIMPLE_NAME="" | ||
| local ABOUT="" | ||
| SIMPLE_NAME="${1}" | ||
| ABOUT=$(os_info ${SIMPLE_NAME} | cut -d'|' -f5) |
| # shellcheck disable=SC1001 | ||
| local DEBOLD=$(wget -q https://cdimage.debian.org/cdimage/archive/ -O- |grep -e '>[1-9][0-9]\.'|grep -v 'live' | cut -d\> -f9|cut -d\/ -f1 ) | ||
| local DEBOLD=$(wget -q https://cdimage.debian.org/cdimage/archive/ -O- | grep -e '>[1-9][0-9]\.' | grep -v 'live' | cut -d\> -f9 | cut -d\/ -f1 ) |
| edubuntu|ubuntu-unity|ubuntucinnamon) | ||
| echo "${INTERIM_SUPPORT[@]}" daily-live | ||
| edubuntu|ubuntu-unity|ubuntucinnamon) | ||
| echo ${INTERIM_SUPPORT[@]} daily-live |
| ## after 14.04 | ||
| echo "${LTS_SUPPORT[@]:1}" "${INTERIM_SUPPORT[@]}" daily-live jammy-daily "${EOL_VERSIONS[@]/#/eol-}" | ||
| echo ${LTS_SUPPORT[@]:1} ${INTERIM_SUPPORT[@]} daily-live jammy-daily #${EOL_VERSIONS[@]/#/eol-} |
| ## after 14.04 | ||
| echo "${LTS_SUPPORT[@]:1}" "${INTERIM_SUPPORT[@]}" daily-live jammy-daily "${EOL_VERSIONS[@]/#/eol-}" | ||
| echo ${LTS_SUPPORT[@]:1} ${INTERIM_SUPPORT[@]} daily-live jammy-daily #${EOL_VERSIONS[@]/#/eol-} |
| #after 16.04 | ||
| echo "${LTS_SUPPORT[@]:2}" "${INTERIM_SUPPORT[@]}" daily-live jammy-daily "${EOL_VERSIONS[@]/#/eol-}" | ||
| echo ${LTS_SUPPORT[@]:2} ${INTERIM_SUPPORT[@]} daily-live jammy-daily #${EOL_VERSIONS[@]/#/eol-} |
| @@ -1780,7 +1787,10 @@ if [ -n "${VM}" ] && [ -e "${VM}" ]; then | |||
| VMPATH=$(realpath "$(dirname "${VM}")") | |||
| VM_MONITOR_SOCKETPATH="${VMDIR}/${VMNAME}-monitor.socket" | |||
| VM_SERIAL_SOCKETPATH="${VMDIR}/${VMNAME}-serial.socket" | |||
|
|
|||
| if [ ! -f "${disk_img}" ]; then | |||
| cd "${VMPATH}" | |||
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
| cd "${VMPATH}" | |
| cd "${VMPATH}" || exit |
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck (suggestion)
quickget|3663|
quickget|3667|
quickget|3669|
quickget|3719|
quickget|3722|
quickget|3829|
| local SIMPLE_NAME="" | ||
| local PRETTY_NAME="" | ||
| SIMPLE_NAME="${1}" | ||
| PRETTY_NAME=$(os_info ${SIMPLE_NAME} | cut -d'|' -f1) |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
| PRETTY_NAME=$(os_info ${SIMPLE_NAME} | cut -d'|' -f1) | |
| PRETTY_NAME=$(os_info "${SIMPLE_NAME}" | cut -d'|' -f1) |
| local SIMPLE_NAME="" | ||
| local BASED="" | ||
| SIMPLE_NAME="${1}" | ||
| BASED=$(os_info ${SIMPLE_NAME} | cut -d'|' -f2) |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
| BASED=$(os_info ${SIMPLE_NAME} | cut -d'|' -f2) | |
| BASED=$(os_info "${SIMPLE_NAME}" | cut -d'|' -f2) |
| local SIMPLE_NAME="" | ||
| local CREDE="" | ||
| SIMPLE_NAME="${1}" | ||
| CREDE=$(os_info ${SIMPLE_NAME} | cut -d'|' -f3) |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
| CREDE=$(os_info ${SIMPLE_NAME} | cut -d'|' -f3) | |
| CREDE=$(os_info "${SIMPLE_NAME}" | cut -d'|' -f3) |
| local SIMPLE_NAME="" | ||
| local HOMEP="" | ||
| SIMPLE_NAME="${1}" | ||
| HOMEP=$(os_info ${SIMPLE_NAME} | cut -d'|' -f4) |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
| HOMEP=$(os_info ${SIMPLE_NAME} | cut -d'|' -f4) | |
| HOMEP=$(os_info "${SIMPLE_NAME}" | cut -d'|' -f4) |
| local SIMPLE_NAME="" | ||
| local ABOUT="" | ||
| SIMPLE_NAME="${1}" | ||
| ABOUT=$(os_info ${SIMPLE_NAME} | cut -d'|' -f5) |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
| ABOUT=$(os_info ${SIMPLE_NAME} | cut -d'|' -f5) | |
| ABOUT=$(os_info "${SIMPLE_NAME}" | cut -d'|' -f5) |
| OS="${1}" | ||
| os_supported | ||
| if command -v neofetch > /dev/null; then | ||
| neofetch -l --ascii_distro ${OS} |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
| neofetch -l --ascii_distro ${OS} | |
| neofetch -l --ascii_distro "${OS}" |
| if command -v neofetch > /dev/null; then | ||
| neofetch -l --ascii_distro ${OS} | ||
| fi | ||
| echo ${OS} |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
| echo ${OS} | |
| echo "${OS}" |
| fi | ||
| echo ${OS} | ||
| echo -n 'Pretty name: ' | ||
| pretty_name ${OS} |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
| pretty_name ${OS} | |
| pretty_name "${OS}" |
| echo -n 'Pretty name: ' | ||
| pretty_name ${OS} | ||
| echo -n 'Based of: ' | ||
| os_basedof ${OS} |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
| os_basedof ${OS} | |
| os_basedof "${OS}" |
| echo -n 'Based of: ' | ||
| os_basedof ${OS} | ||
|
|
||
| if [ -z "$(os_credentials ${OS})" ]; then |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
| if [ -z "$(os_credentials ${OS})" ]; then | |
| if [ -z "$(os_credentials "${OS}")" ]; then |
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
No description provided.