Fix Github Actions CI #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This makes the CI check succeed on my fork, so it should fix it here as well. Apologies if I'm misunderstanding the way this is currently being done, but I figured CI should succeed when possible. If the purpose of
../amethystwas to allow a separate local install of Amethyst (i.e. to avoid long recompiles), then there should still be a fix for CI. For example, an alternate build configuration could be specified for CI, or maybe a caching system could be used for Github Actions.Very cool project, by the way! I discovered it through the Youtube video, and it looks like exactly the kind of ambitious project that the community needs.