Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove sync track to and from scene and back to track nodes #17923

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

pollend
Copy link
Member

@pollend pollend commented May 16, 2024

What does this PR do?

I've been investigated this for a little bit. I would like some background information for syncing a track to and from the scene and back. For the UI trackview this code has been ifdefed out? I can't find any material or documentation related to this so I'm not sure what the usecase is for?.

image

@pollend pollend requested a review from a team as a code owner May 16, 2024 05:05
@byrcolin byrcolin added the sig/content Categorizes an issue or PR as relevant to SIG Content. label May 21, 2024
Copy link
Contributor

@nick-l-o3de nick-l-o3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the code, the body of this has been ifdef'd out since Cry Entities were gone, we should remove these buttons until such a time as it makes sense to bring them back.

I believe their purpose was to copy the objects transforms from the scene to the track view at current time, and back, which is a reasonable operation to support, but I'm not going to ask someone to support that feature if its been not working for literally years unless they have hte bandwidht to implement it. I imagine there's some way to do it - that is, whatever the new way to query transforms is and nodes.

BUt we can add it back if its needed.

@pollend
Copy link
Member Author

pollend commented Jun 8, 2024

looking at the code, the body of this has been ifdef'd out since Cry Entities were gone, we should remove these buttons until such a time as it makes sense to bring them back.

I believe their purpose was to copy the objects transforms from the scene to the track view at current time, and back, which is a reasonable operation to support, but I'm not going to ask someone to support that feature if its been not working for literally years unless they have hte bandwidht to implement it. I imagine there's some way to do it - that is, whatever the new way to query transforms is and nodes.

BUt we can add it back if its needed.

that sounds good, the track and view are always in sync so the buttons do not seem to serve a purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/content Categorizes an issue or PR as relevant to SIG Content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants