Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script canvas logger can now identify graph and entity names #17912

Merged

Conversation

guillaume-haerinck
Copy link
Contributor

@guillaume-haerinck guillaume-haerinck commented May 12, 2024

What does this PR do?

Work on #9192, #2583, #17643, #10795. Script canvas logger can now show graph names and entity names. Code has been mostly restored to the Lumberyard's state.

GraphInfo class has been moved back to its old state so that it can be serialized (only used by the debugger to send remote messages, make no sense to hold a ptr to execution state there)

There are two things which still needs to be done to have all of the functionnalities back:

inaction.mp4

How was this PR tested?

Locally against the newspaper sample project, with multiple graphs

@guillaume-haerinck guillaume-haerinck requested a review from a team as a code owner May 12, 2024 07:58
Copy link
Contributor

@lsemp3d lsemp3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thank you for taking it on!

@guillaume-haerinck
Copy link
Contributor Author

Some context for future ref about the focus issue :
In GraphSerialization.cpp, on graph open and graph save done via Deserialize(), all of the node Ids are randomized via MakeGraphComponentEntityIdsUnique(). If I disable this behavior and grab the graph I'm able to have a match between my debugger nodeIds and the runtime graph nodeIds, (and focus works after that).

Fix will be to track these remapped IDs and get them on demand, as it was possible before.

@spham-amzn
Copy link
Contributor

Looks like a legit n AR failure:

[2024-05-12T15:26:47.430Z] /usr/bin/clang++-12 -DAZ_BUILD_CONFIGURATION_TYPE=\"profile\" -DAZ_ENABLE_DEBUG_TOOLS -DAZ_ENABLE_TRACING -DAZ_PROFILE_BUILD -DENABLE_EXTENDED_MATH_SUPPORT=0 -DLINUX -DLINUX64 -DNDEBUG -DSCRIPTCANVAS -DSCRIPTCANVAS_ERRORS_ENABLED -DSC_EXECUTION_TRACE_ENABLED -D_FORTIFY_SOURCE=2 -D_HAS_EXCEPTIONS=0 -D_PROFILE -D__linux__ -DCMAKE_INTDIR=\"profile\" -I/data/workspace/o3de/Gems/ScriptCanvas/Code/. -I/data/workspace/o3de/Gems/ScriptCanvas/Code/Include -I/data/workspace/o3de/Gems/ScriptCanvas/Code/Include/ScriptCanvas -I/data/workspace/o3de/build/linux/External/ScriptCanvas-8caffd05/Code/Azcg/Generated/ScriptCanvas.API -I/data/workspace/o3de/Code/Framework/AzCore/. -I/data/workspace/o3de/Code/Framework/AzCore/Platform/Linux -I/data/workspace/o3de/Code/Framework/AzCore/Platform/Common -I/data/workspace/o3de/Code/Framework/AzFramework/. -I/data/workspace/o3de/Code/Framework/AzFramework/Platform/Linux -I/data/workspace/o3de/Code/Framework/AzNetworking/. -I/data/workspace/o3de/Code/Framework/AzNetworking/Platform/Common -I/data/workspace/o3de/Code/Framework/AzNetworking/Platform/Linux -I/data/workspace/o3de/build/linux/Code/Framework/AzNetworking/Azcg/Generated/AzNetworking -I/data/workspace/o3de/Gems/ScriptEvents/Code/Include -I/data/workspace/o3de/Gems/ExpressionEvaluation/Code/Include -isystem /data/workspace/3rdParty/packages/Lua-5.4.4-rev1-linux/Lua/include -isystem /data/workspace/3rdParty/packages/RapidJSON-1.1.0-rev1-multiplatform/RapidJSON/include -isystem /data/workspace/3rdParty/packages/RapidXML-1.13-rev1-multiplatform/RapidXML/include -isystem /data/workspace/3rdParty/packages/zlib-1.2.11-rev5-linux/zlib/include -isystem /data/workspace/3rdParty/packages/cityhash-1.1-multiplatform/cityhash/src -isystem /data/workspace/3rdParty/packages/lz4-1.9.4-rev2-linux/lz4/include -fno-exceptions -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Werror -Wno-inconsistent-missing-override -Wrange-loop-analysis -Wno-unknown-warning-option -Wno-parentheses -Wno-reorder -Wno-switch -Wno-undefined-var-template -msse4.1  -O2 -g -fstack-protector-all -fstack-check -fPIC -std=c++17 -MD -MT External/ScriptCanvas-8caffd05/Code/CMakeFiles/ScriptCanvas.API.dir/profile/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedDebugAPI.cpp.o -MF External/ScriptCanvas-8caffd05/Code/CMakeFiles/ScriptCanvas.API.dir/profile/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedDebugAPI.cpp.o.d -o External/ScriptCanvas-8caffd05/Code/CMakeFiles/ScriptCanvas.API.dir/profile/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedDebugAPI.cpp.o -c /data/workspace/o3de/Gems/ScriptCanvas/Code/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedDebugAPI.cpp

[2024-05-12T15:26:47.430Z] /data/workspace/o3de/Gems/ScriptCanvas/Code/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedDebugAPI.cpp:204:31: error: unused variable 'subgraphId' [-Werror,-Wunused-variable]

[2024-05-12T15:26:47.430Z]             AZ::Data::AssetId subgraphId = AZ::Data::AssetId::CreateString(assetIdString);

[2024-05-12T15:26:47.430Z]                               ^

@guillaume-haerinck
Copy link
Contributor Author

Looks like a legit n AR failure:

[2024-05-12T15:26:47.430Z] /usr/bin/clang++-12 -DAZ_BUILD_CONFIGURATION_TYPE=\"profile\" -DAZ_ENABLE_DEBUG_TOOLS -DAZ_ENABLE_TRACING -DAZ_PROFILE_BUILD -DENABLE_EXTENDED_MATH_SUPPORT=0 -DLINUX -DLINUX64 -DNDEBUG -DSCRIPTCANVAS -DSCRIPTCANVAS_ERRORS_ENABLED -DSC_EXECUTION_TRACE_ENABLED -D_FORTIFY_SOURCE=2 -D_HAS_EXCEPTIONS=0 -D_PROFILE -D__linux__ -DCMAKE_INTDIR=\"profile\" -I/data/workspace/o3de/Gems/ScriptCanvas/Code/. -I/data/workspace/o3de/Gems/ScriptCanvas/Code/Include -I/data/workspace/o3de/Gems/ScriptCanvas/Code/Include/ScriptCanvas -I/data/workspace/o3de/build/linux/External/ScriptCanvas-8caffd05/Code/Azcg/Generated/ScriptCanvas.API -I/data/workspace/o3de/Code/Framework/AzCore/. -I/data/workspace/o3de/Code/Framework/AzCore/Platform/Linux -I/data/workspace/o3de/Code/Framework/AzCore/Platform/Common -I/data/workspace/o3de/Code/Framework/AzFramework/. -I/data/workspace/o3de/Code/Framework/AzFramework/Platform/Linux -I/data/workspace/o3de/Code/Framework/AzNetworking/. -I/data/workspace/o3de/Code/Framework/AzNetworking/Platform/Common -I/data/workspace/o3de/Code/Framework/AzNetworking/Platform/Linux -I/data/workspace/o3de/build/linux/Code/Framework/AzNetworking/Azcg/Generated/AzNetworking -I/data/workspace/o3de/Gems/ScriptEvents/Code/Include -I/data/workspace/o3de/Gems/ExpressionEvaluation/Code/Include -isystem /data/workspace/3rdParty/packages/Lua-5.4.4-rev1-linux/Lua/include -isystem /data/workspace/3rdParty/packages/RapidJSON-1.1.0-rev1-multiplatform/RapidJSON/include -isystem /data/workspace/3rdParty/packages/RapidXML-1.13-rev1-multiplatform/RapidXML/include -isystem /data/workspace/3rdParty/packages/zlib-1.2.11-rev5-linux/zlib/include -isystem /data/workspace/3rdParty/packages/cityhash-1.1-multiplatform/cityhash/src -isystem /data/workspace/3rdParty/packages/lz4-1.9.4-rev2-linux/lz4/include -fno-exceptions -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Werror -Wno-inconsistent-missing-override -Wrange-loop-analysis -Wno-unknown-warning-option -Wno-parentheses -Wno-reorder -Wno-switch -Wno-undefined-var-template -msse4.1  -O2 -g -fstack-protector-all -fstack-check -fPIC -std=c++17 -MD -MT External/ScriptCanvas-8caffd05/Code/CMakeFiles/ScriptCanvas.API.dir/profile/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedDebugAPI.cpp.o -MF External/ScriptCanvas-8caffd05/Code/CMakeFiles/ScriptCanvas.API.dir/profile/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedDebugAPI.cpp.o.d -o External/ScriptCanvas-8caffd05/Code/CMakeFiles/ScriptCanvas.API.dir/profile/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedDebugAPI.cpp.o -c /data/workspace/o3de/Gems/ScriptCanvas/Code/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedDebugAPI.cpp

[2024-05-12T15:26:47.430Z] /data/workspace/o3de/Gems/ScriptCanvas/Code/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedDebugAPI.cpp:204:31: error: unused variable 'subgraphId' [-Werror,-Wunused-variable]

[2024-05-12T15:26:47.430Z]             AZ::Data::AssetId subgraphId = AZ::Data::AssetId::CreateString(assetIdString);

[2024-05-12T15:26:47.430Z]                               ^

That's weird the line is commented out, maybe you got the report from the old build

@guillaume-haerinck
Copy link
Contributor Author

Yeah if you check the last report attached, it failed because of a timeout on linux build, but android passed

@byrcolin byrcolin added the sig/content Categorizes an issue or PR as relevant to SIG Content. label May 14, 2024
@guillaume-haerinck guillaume-haerinck changed the base branch from development to stabilization/2409 May 19, 2024 19:35
@guillaume-haerinck
Copy link
Contributor Author

Now targeting stabilization branch

@lsemp3d lsemp3d merged commit 5a896bd into o3de:stabilization/2409 May 25, 2024
3 checks passed
@guillaume-haerinck guillaume-haerinck deleted the scriptcanvas-logger branch May 26, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/content Categorizes an issue or PR as relevant to SIG Content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants