-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script canvas logger can now identify graph and entity names #17912
Script canvas logger can now identify graph and entity names #17912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, thank you for taking it on!
Some context for future ref about the focus issue : Fix will be to track these remapped IDs and get them on demand, as it was possible before. |
...criptCanvas/Code/Include/ScriptCanvas/Execution/Interpreted/ExecutionInterpretedDebugAPI.cpp
Outdated
Show resolved
Hide resolved
Gems/ScriptCanvas/Code/Editor/View/Widgets/LoggingPanel/LoggingWindowSession.cpp
Outdated
Show resolved
Hide resolved
05fff0c
to
78f02b0
Compare
Looks like a legit n AR failure:
|
That's weird the line is commented out, maybe you got the report from the old build |
Yeah if you check the last report attached, it failed because of a timeout on linux build, but android passed |
78f02b0
to
e9aa0a6
Compare
e9aa0a6
to
ca2ed97
Compare
Now targeting stabilization branch |
ca2ed97
to
1084474
Compare
Signed-off-by: guillaume-haerinck <[email protected]>
1084474
to
b43554d
Compare
Signed-off-by: guillaume-haerinck <[email protected]>
What does this PR do?
Work on #9192, #2583, #17643, #10795. Script canvas logger can now show graph names and entity names. Code has been mostly restored to the Lumberyard's state.
GraphInfo class has been moved back to its old state so that it can be serialized (only used by the debugger to send remote messages, make no sense to hold a ptr to execution state there)
There are two things which still needs to be done to have all of the functionnalities back:
inaction.mp4
How was this PR tested?
Locally against the newspaper sample project, with multiple graphs