Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace (almost) all parsable enums to an enum-like class #665

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

Rapougnac
Copy link
Member

Description

Connected issues & other potential problems

Closes #661

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (it's a partial breaking change?)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Rapougnac Rapougnac self-assigned this Jun 18, 2024
@Rapougnac Rapougnac added bug Something isn't working enhancement New feature or request labels Jun 18, 2024
@Rapougnac Rapougnac added this to the 6.3.0 milestone Jun 18, 2024
Copy link
Member

@abitofevrything abitofevrything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also deprecate all the parse constructors? They will probably be removed eventually considering that they're now just duplicate functionality.

lib/src/utils/enum_like.dart Outdated Show resolved Hide resolved
Co-authored-by: Abitofevrything <[email protected]>
@Rapougnac Rapougnac merged commit 0a212fd into nyxx-discord:dev Jun 24, 2024
3 checks passed
@Rapougnac Rapougnac deleted the feat/super-enum-unknown branch June 24, 2024 12:55
abitofevrything added a commit that referenced this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Hang Status is not handled
3 participants