Don't show loading state so low down #462
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes
The current styling assumes this mailbox will be the only component on the screen. If it's included in a UI that has something above it, that means the loading UI may even be below the fold, making the UI appear blank & broken until loading finishes. In error states, when loading never finishes, it's even worse. The sizing of the loading screen should be the responsibility of the consumer, as it knows the size the component should be.
Edit: here's a writeup that I've previously sent to Nylas Product Management:
Readiness checklist
CHANGELOG.md
component/src/properties.json
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.