Extract more details for mounts.json

[jnovack]

Correct and Extract additional details for mounts.

• Added AttributeId so replay processors can reference.
• Added MountCategory for no good reason other than my OCD.
• Corrected Universe default to Custom rather than StarCraft. The rewards (Void Speeder, MechoSpider, Vulture, etc) do NOT have Universes and we cannot assume they belong to any Universe (StarCraft, Heroes, or otherwise).

Closes #3

[Sembiance]

Added AttributeId and MountCategory.

The default category remains Starcraft. There were 10 mounts that had no category in the XML, yet if you look at them, all but one of them are from the starcraft universe and several even mention it in their descriptions. The 1 that wasn't appears to be from the Warcraft universe as it mentions gnomish engineers.

The heroes use the same system, with the default being Starcraft, otherwise there wouldn't be any Starcraft heroes. Internally HoTS uses the Starcraft 2 engine, so it's a bit of a holdover that this default remains.

[jnovack]

I respectfully disagree.

less MountData.xml | grep -E "<CMount|Universe" | sed '1,/Universe/d'

The above command shows there are quite a bit of mounts that do not have Universes.

    <CMount id="VoidSpeeder">
    <CMount id="VoidSpeederBlue">
    <CMount id="VoidSpeederPurple">
    <CMount id="CountessKerriganBatForm">
    <CMount id="MechaTassadarMorphForm">
    <CMount id="CyberWolf">
    <CMount id="CyberWolfGrey">
    <CMount id="CyberWolfYellow">
    <CMount id="CyberWolfGold">
    <CMount id="CyberWolfBronze">
    <CMount id="CyberWolfPlat">
    <CMount id="Mechanospider">
    <CMount id="SpiderMountBlack">
    <CMount id="SpiderMountRed">
    <CMount id="TigerGoldObsidian">
    <CMount id="TigerGoldChrome">
    <CMount id="TigerLunarBlue">
    <CMount id="TigerLunarGreen">
    <CMount id="Vulture">
    <CMount id="VultureBaseVar1">
    <CMount id="VultureBaseVar2">

The animals (wolves, spiders, and tigers) are from Warcraft, while the rest are from Starcraft. In fact, they even tag LunarTiger with Warcraft. and the TigerLunarBlue is a color variant of LunarTiger.

The proper way to tie TigerLunarBlue with LunarTiger is to reference the Model value.

Tagging these with Starcraft by default is definitely wrong.

[Sembiance]

I agree.

I don't currently include any of the variations in the mounts.json file, which is why many of these other mounts didn't come up in my testing.

The code no longer has any default and each mount is corrected as needed. The code warns if mount doesn't contain a franchise and I will tag it correctly when that happens.