[Fix] gracefully handle GNU tar on MacOS during nvm install
#3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNU tar doesn't support using the -J flag required to unpack xz-compressed tarballs when xv isn't installed. Check for this scenario and fallback to using gzip-compressed tarballs. Fixes nvm-sh#3034
ljharb
reviewed
Aug 27, 2023
There was a problem hiding this comment.
it'd be great to add this to the nvm_supports_xz unit tests - we'd have to mock out nvm_get_os to be darwin, and then put a tar on the path whose --version output matched gnu tar's, and make sure there's no xz on the path, and then we could assert it returns 1?
| @@ -4325,7 +4325,11 @@ nvm_supports_xz() { | |||
| if [ "_${NVM_OS}" = '_darwin' ]; then | |||
| local MACOS_VERSION | |||
| MACOS_VERSION="$(sw_vers -productVersion)" | |||
| if nvm_version_greater "10.9.0" "${MACOS_VERSION}"; then | |||
| if tar --version | command grep -q GNU && ! command which xz >/dev/null 2>&1; then | |||
There was a problem hiding this comment.
Suggested change
| if tar --version | command grep -q GNU && ! command which xz >/dev/null 2>&1; then | |
| if command tar --version | command grep -q GNU && ! command which xz >/dev/null 2>&1; then |
|
@tim-mit are you still interested in completing this PR? |
ljharb
force-pushed
the
master
branch
2 times, most recently
from
c6cfc3a
to
c20db2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNU tar doesn't support using the -J flag required to unpack xz-compressed tarballs when xv isn't installed. Check for this scenario and fallback to using gzip-compressed tarballs.
Fixes #3034