Update README.md | Update Auto-disable Example #6676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since `vim.loop` is deprecated, updated the function.
|
That's about the sort of PR I would expect from a glorified Markov chain. |
|
Wow! Having outdated examples in your document isn't a good thing. you seem like a small person. |
lucario387
reviewed
May 23, 2024
Comment on lines
+134
to
+140
| local max_filesize = 100 * 1024 -- 100 KB | ||
| local filename = vim.api.nvim_buf_get_name(buf) | ||
| local file_size = vim.fn.getfsize(filename) | ||
|
|
||
| if file_size > max_filesize then | ||
| return true | ||
| end |
There was a problem hiding this comment.
getfsize returns -1, which doesn't seem to be handled here?
Additionally, why not just move vim.loop to vim.uv now that vim.uv is in latest release version of Neovim?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since
vim.loopis deprecated, updated the function.This is also more concise and easier to understand.
Written with help from chatGPT3.5 turbo