Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uninstall): use correct path separator on windows #6369

Merged
merged 2 commits into from
Mar 31, 2024
Merged

fix(uninstall): use correct path separator on windows #6369

merged 2 commits into from
Mar 31, 2024

Conversation

qgates
Copy link
Contributor

@qgates qgates commented Mar 27, 2024

Addressed bug/issue #5756

@clason
Copy link
Contributor

clason commented Mar 29, 2024

I think this should use the clean_path function below (and same for other paths that need to be normalized on Windows -- can you check for those and give them the same treatment if necessary?)

@ObserverOfTime ObserverOfTime changed the title Fix uninstall to use correct path separator for on Win fix(uninstall): use correct path separator on windows Mar 29, 2024
@qgates
Copy link
Contributor Author

qgates commented Mar 31, 2024

Ok thanks, will take a look. Fine with lua but new to working on nvim plugins (go easy on me pls!) question:

Installed to nvim via Lazy, but git head detached by default. What's the best workflow for fixing/contrib on this (and other) plugin repos... manually clone into default lazy install dir? or is there a Lazy config that allows me to work with cloned repos instead of default plugin install path?

Apologies if this is explained somewhere, didn't find it.

🙂

@qgates
Copy link
Contributor Author

qgates commented Mar 31, 2024

@clason commit 79cf503 updates top level funcs install / uninstall to use clean_path as suggested

@clason clason merged commit ff79725 into nvim-treesitter:master Mar 31, 2024
9 checks passed
@qgates qgates deleted the patch-1 branch April 1, 2024 04:09
Lemi0002 pushed a commit to Lemi0002/nvim-treesitter that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants