fix(help_tags): show help tags on windows (#3126) #3127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows,
builtin.help_tags
picker does not show any help tags.To fix this, the following changes are needed:
util.path_tail
checks unix separator/
on Windows and leave the original implementation intact on unix systems.Line endings should be taken carefully on Windows.
vim.split
with only newline\n
character as separator may result in unexpected crash when parsing large files. When splits on lines are needed, call it with\r?\n
, or even set up a wrapper function in utils is more prefered.Fixes #3126
Description
Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context
Fixes #3126 (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
util.path_tail
on Windows, Linux, and MacOSutil.split_lines
on Windows, Linux and MacOSConfiguration:
Checklist: