Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update remote plugins after install/update #485

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Jul 27, 2024

No description provided.

@mrcjkb mrcjkb force-pushed the update-remote-plugins branch from 95c5855 to 78bdee3 Compare July 27, 2024 13:54
@mrcjkb mrcjkb merged commit 3218e4f into master Jul 28, 2024
@mrcjkb mrcjkb deleted the update-remote-plugins branch July 28, 2024 08:49
@teto
Copy link
Member

teto commented Jul 29, 2024

I am curious what was the request asking for it . Note that justin seems to be actively trying to remove remote plugins so maybe this could have been a RocksPostSync hook instead.

@mrcjkb
Copy link
Member Author

mrcjkb commented Jul 29, 2024

I am curious what was the request asking for it . Note that justin seems to be actively trying to remove remote plugins so maybe this could have been a RocksPostSync hook instead.

There wasn't a request. I just realised that remote plugins are still a thing and they typically tell people to put build = ':UpdateRemotePlugins' in their install instructions.
Since the command only needs to be run once after install/update/sync, it doesn't have a significant impact on performance and I see no harm in adding it.

@teto
Copy link
Member

teto commented Jul 29, 2024

yes it's a good idea but I saw you were going to release rocks.nvim and I thought I would suggest a more generic event (thought not sure how one would use a PostSync event, maybe to rebuild stuff) that could survive a breaking change.

@mrcjkb
Copy link
Member Author

mrcjkb commented Jul 29, 2024

I think user events could be a good idea.
rocks.nvim extensions could hook into them too.
We could also have events for RocksFooCachePopulated or RocksFooCacheUpdated, which might be useful for rocks-edit.nvim.

Let's create an issue for it and collect ideas.

@mrcjkb mrcjkb mentioned this pull request Jul 29, 2024
@mrcjkb
Copy link
Member Author

mrcjkb commented Aug 5, 2024

neovim/neovim#27949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants