-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several fixups for unicode normalization #16584
Several fixups for unicode normalization #16584
Conversation
See test results for failed build of commit 8147d2e76b |
See test results for failed build of commit 740467ce53 |
See test results for failed build of commit b9ed18e76b |
@burmancomp reported a zero division error when doing: |
See test results for failed build of commit e687938887 |
3185531
to
5f3f0f8
Compare
I think for now, we could probably best leave this as is. Note that there are still some open questions, but these can be handled in a follow up:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LeonarddeR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@LeonarddeR - are these 2 things tracked in a separate issue or discussion? I think they'd be good to discuss for 2024.4 |
Link to issue number:
Fixup of #16521
Fixes #11570
Partial fix for #4631
Summary of the issue:
Description of user facing changes
No longer errors in the log when getting flash messages in Thunderbird and/or reading messages in WhatsApp UWP.
Description of development approach
Testing strategy:
From a python console
braille.TextRegion("ij").update()
No longer results in an error.
Same for
braille.TextRegion("\xa0 ").update()
Known issues with pull request:
None known
Code Review Checklist: