Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added security and privacy note for when installing add-ons to the user guide #16316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions user_docs/en/userGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,8 @@ There will also be a button present to review the add-ons that will be disabled.
Refer to the [incompatible add-ons dialog section](#incompatibleAddonsManager) for more help on this button.
After installation, you are able to re-enable incompatible add-ons at your own risk from within the [Add-on Store](#AddonsManager).

Note that add-ons might introduce vulnerabilities, so check out the [note on security and privacy](#AddonSecurityAndPrivacy) to make sure you have all information needed before installing them.

#### Use NVDA during sign-in {#StartAtWindowsLogon}

This option allows you to choose whether or not NVDA should automatically start while at the Windows sign-in screen, before you have entered a password.
Expand Down Expand Up @@ -3322,6 +3324,34 @@ If you install an add-on with paid components and change your mind about using i
The Add-on Store is accessed from the Tools submenu of the NVDA menu.
To access the Add-on Store from anywhere, assign a custom gesture using the [Input Gestures dialog](#InputGestures).

## Note on security and privacy when using Add-ons {#AddonSecurityAndPrivacy}
Installing add-ons leads to the integration of non-NV Access code into NVDA, in order to enhance NVDA or make new features possible.
Add-ons can be created by any person or organization.
They may include or utilize external components and third party services to serve their purpose and provide the features for which they have been developed.

Automated tests of add-ons happen before they are published in the NVDA Add-on Store.
These include a basic automated check for vulnerabilities by security analysis tools such as [CodeQL](https://codeql.github.com/).
Add-ons are not reviewed by NV Access staff before publication to the Add-on Store, but from time to time NV Access lets [VirusTotal](https://docs.virustotal.com/docs/how-it-works) check the vulnerability of add-ons.
Additionally, many add-ons have discussion areas where users can leave feedback.
The [community reviews area](#AddonStoreReviews) can be accessed via the actions menu of each add-on.

As a general rule, NVDA's add-ons or third-party extensions in other software such as browsers, have the potential to introduce security and/or privacy vulnerabilities, depending on the permissions they need and actions they perform in order to provide their stated functionality.
Risks may include, but are not limited to:

* Insecure network connections
* Files stored with insecure file permissions or in an unprotected location
* Writing sensitive information to a log file without notifying the user
* Vulnerabilities in third-party libraries
* Cryptographic vulnerabilities

Users install NVDA add-ons at their own risk.
Therefore, the following considerations should be kept in mind when installing them:

* If the developer has a website, spend some time evaluating whether it appears to be a serious source you can trust.
* Read the description carefully. Does the add-on need questionable permissions? Does it track data? Does it share sensitive data with other sources that you don’t trust?
* Check out the [community reviews #AddonStoreReviews] for the add-on. Are there any complaints about the add-on? Are there any reports about data being taken, or for anything that makes you feel unsafe?
* The risk of vulnerabilities increases the more add-ons you installed. Therefore, be sure to remain aware of where you are downloading your add-ons from. Sources other than the official NVDA Add-on Store may be malicious, may include out of date versions, or may not perform any quality checks.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a detail:
There is no concept of "official" Add-on Store and unofficial ones. The Add-on Store is just a part of NVDA as the settings dialog or the update window is. There is just the Add-on Store, and alternative ways to download add-ons. Thus I'd drop "official".

Suggested change
* The risk of vulnerabilities increases the more add-ons you installed. Therefore, be sure to remain aware of where you are downloading your add-ons from. Sources other than the official NVDA Add-on Store may be malicious, may include out of date versions, or may not perform any quality checks.
* The risk of vulnerabilities increases the more add-ons you installed. Therefore, be sure to remain aware of where you are downloading your add-ons from. Sources other than NVDA's Add-on Store may be malicious, may include out of date versions, or may not perform any quality checks.


### Browsing add-ons {#AddonStoreBrowsing}

When opened, the Add-on Store displays a list of add-ons.
Expand Down