Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added security and privacy note for add-ons to the user guide #16311

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions user_docs/en/userGuide.t2t
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ Before you're able to press the Continue button you will have to use the checkbo
There will also be a button present to review the add-ons that will be disabled.
Refer to the [incompatible add-ons dialog section #incompatibleAddonsManager] for more help on this button.
After installation, you are able to re-enable incompatible add-ons at your own risk from within the [Add-on Store #AddonsManager].
But note that add-ons might introduce vulnerabilities, so check out the [note on security and privacy #AddonSecurityandPrivacy] to make sure you have all information needed before installing them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting the sentence with 'but' seems strange. Perhaps something like:

Suggested change
But note that add-ons might introduce vulnerabilities, so check out the [note on security and privacy #AddonSecurityandPrivacy] to make sure you have all information needed before installing them.
Please note that add-ons might introduce vulnerabilities, so check out the [note on security and privacy #AddonSecurityandPrivacy] to make sure you have all information needed before installing them.

cc @XLTechie for a native English speaker opinion.


+++ Use NVDA during sign-in +++[StartAtWindowsLogon]
This option allows you to choose whether or not NVDA should automatically start while at the Windows sign-in screen, before you have entered a password.
Expand Down Expand Up @@ -2925,6 +2926,32 @@ If you install an add-on with paid components and change your mind about using i
The Add-on Store is accessed from the Tools submenu of the NVDA menu.
To access the Add-on Store from anywhere, assign a custom gesture using the [Input Gestures dialog #InputGestures].

++ Note on security and privacy when using Add-ons ++[AddonSecurityandPrivacy]
Installing add-ons in NVDA leads to integration of external code into NVDA's functionality in order to enhance NVDA or make new features possible.
Add-ons can also use external libraries and third party services to serve the purpose and provide the features for which they have been developed.
Add-ons can be developed by every person or company, and the review process for these external feature providers happens when they are submitted to the NVDA’s official add-on store.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since add-on store was introduced review become optional. As a result most add-ons are not reviewed at all.


The review process of add-ons is still in development, so most of add-ons are not officially reviewed yet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'officially' here implies 'by NV Access', which was never the case and probably never would.

However, many add-ons have discussions areas where users can exchange feedback. The [community review area #AddonStoreReviews] can be accessed via the actions menu of the add-on.

Installed Add-ons or extensions (not only in NVDA) might in general introduce security and/or privacy vulnerabilities, depending on the permissions they need and actions they perform in order to provide the desired functionality.
Risks can be e.g.
- Insecure network connections
- Files stored with insecure file permissions or in an unprotected location
- Sensitive information written to an easily available log file
- Web browser vulnerabilities
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This risk seems irrelevant to NVDA add-ons.

- Vulnerabilities in third-party libraries
- Cryptographic vulnerabilities, and more.
-

Users install NVDA add-ons at their own risk. Therefore, everyone should be aware of following aspects when installing them:
- Check out the developer’s website to see if it’s a serious source you can trust.
- Read the description carefully. Does the add-on need questionable permissions? Does it track data? Does it share sensitive data with other sources that you don’t trust?
- Check out the [community reviews #AddonStoreReviews] for the add-on. Are there any complaints about the add-on? Are there any reports about data being taken, or for anything that makes you feel unsafe?
- The risk of vulnerabilities increases the more add-ons you installed. So be careful to keep the overview of the sources your add-ons come from.
- If possible, check the permissions the add-on requests. If you don’t feel safe about a permission the add-on needs, maybe it is better to uninstall it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How I am supposed to do this? Honestly I'd suggest to remove mention of permissions until and unless NVDA introduces a permissions system for add-ons.

-

++ Browsing add-ons ++[AddonStoreBrowsing]
When opened, the Add-on Store displays a list of add-ons.
If you have not installed an add-on before, the Add-on Store will open to a list of add-ons available to install.
Expand Down