Skip to content

Add link to the submitters guide to improve validation errors message #10776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvdaes wants to merge 5 commits into
base: master
Choose a base branch
from
+4 −1
Open

Add link to the submitters guide to improve validation errors message #10776

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10b1275
Add link to the submitters guide to improve validation errors message
nvdaes Aug 11, 2026
25d39ad
Add dot to sentence
nvdaes Aug 11, 2026
a42576f
Improve message for invalid manifest version when creating the json file
nvdaes Aug 13, 2026
9efdd41
Pre-commit auto-fix
pre-commit-ci[bot] Aug 13, 2026
3c85214
Pre-commit auto-fix
pre-commit-ci[bot] Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions validation/_validate/validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ def outputErrors(errors: list[str], errorFilePath: str | None = None):
errorFile.write(
"This add-on submission has validation errors. "
"Please submit a new version with the errors fixed. "
"To get help fixing the errors, read the Add-on Manifest Validation section of the [Submission Guide](https://github.com/nvaccess/addon-datastore/blob/master/docs/submitters/submissionGuide.md#add-on-manifest-validation) "
"Errors:\n- " + "\n- ".join(errors) + "\n\n",
Comment on lines 408 to 411

@seanbudd seanbudd Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you consider this suggestion?

)

Expand Down
Loading