Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): improve interactive modules selector #785

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DamianGlowala
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

A few small improvements and fixes I didn't manage to address on time in #781:

  • removing full stop from description only from the end (purely for future proofing)
  • applying two conditions in a single .filter()
  • forwarding log level arg via module add to prepare command it uses
  • skipping running prepare command if skipInstall is passed (otherwise we're getting errors!)

@DamianGlowala DamianGlowala requested a review from danielroe as a code owner March 8, 2025 08:56
Copy link
Contributor

github-actions bot commented Mar 8, 2025

Bundle Stats β€” create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
49 5.72 MB β†’ 5.72 MB (+134 B) +0.00%
Changeset
File Ξ” Size
home/runner/work/cli/cli/packages/nuxi/src/commands/init.ts πŸ“ˆ +91 B (+1.25%) 7.11 kB β†’ 7.2 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/module/add.ts πŸ“ˆ +43 B (+0.41%) 10.32 kB β†’ 10.37 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/create-nuxt.Co5pXpKk.mjs 0 B β†’ 2.02 MB (+2.02 MB) -
shared/create-nuxt.B9CW-VNu.mjs 0 B β†’ 945.04 kB (+945.04 kB) -
shared/create-nuxt.Wf-_aB5h.mjs 0 B β†’ 108.13 kB (+108.13 kB) -
shared/create-nuxt.CK7uSP-R.mjs 0 B β†’ 18.95 kB (+18.95 kB) -
shared/create-nuxt.n7NLDxL3.mjs 0 B β†’ 14.64 kB (+14.64 kB) -
shared/create-nuxt.khZj85gX.mjs 0 B β†’ 4.07 kB (+4.07 kB) -
shared/create-nuxt.C589ZZ7Q.mjs 0 B β†’ 3.9 kB (+3.9 kB) -
shared/create-nuxt.BzjN9d_r.mjs 0 B β†’ 836 B (+836 B) -
shared/create-nuxt.C-v8Gy_P.mjs 0 B β†’ 804 B (+804 B) -
shared/create-nuxt.DkkW2ZyM.mjs 0 B β†’ 715 B (+715 B) -
shared/create-nuxt.DKRWrVZV.mjs 0 B β†’ 294 B (+294 B) -

Removed

Asset File Size % Changed
shared/create-nuxt.C8xw6lex.mjs 2.02 MB β†’ 0 B (-2.02 MB) -100%
shared/create-nuxt.DPNCFUgS.mjs 944.96 kB β†’ 0 B (-944.96 kB) -100%
shared/create-nuxt.Tuub8dkf.mjs 108.13 kB β†’ 0 B (-108.13 kB) -100%
shared/create-nuxt.Bg2MsAUI.mjs 18.95 kB β†’ 0 B (-18.95 kB) -100%
shared/create-nuxt.Bp9rbz1P.mjs 14.64 kB β†’ 0 B (-14.64 kB) -100%
shared/create-nuxt.Umjto0iq.mjs 4.07 kB β†’ 0 B (-4.07 kB) -100%
shared/create-nuxt.Db5w2sD5.mjs 3.9 kB β†’ 0 B (-3.9 kB) -100%
shared/create-nuxt.bP8fxh52.mjs 836 B β†’ 0 B (-836 B) -100%
shared/create-nuxt.zXdOcxCQ.mjs 804 B β†’ 0 B (-804 B) -100%
shared/create-nuxt.Bz07-tpP.mjs 715 B β†’ 0 B (-715 B) -100%
shared/create-nuxt.BMcmU3YJ.mjs 294 B β†’ 0 B (-294 B) -100%

Bigger

Asset File Size % Changed
chunks/add2.mjs 12.21 kB β†’ 12.25 kB (+43 B) +0.34%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 1.07 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 1.96 kB 0%
chunks/dev.mjs 7.48 kB 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.22 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.25 kB 0%
chunks/prompt.mjs 42.92 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/kit.mjs 1.34 kB 0%
chunks/index2.mjs 1.17 MB 0%
chunks/dev2.mjs 70 kB 0%
chunks/index3.mjs 17.14 kB 0%
chunks/index4.mjs 71.98 kB 0%
chunks/search.mjs 45.83 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 134.23 kB 0%
chunks/index5.mjs 1.23 kB 0%
chunks/index6.mjs 6.25 kB 0%
chunks/index7.mjs 50.51 kB 0%
chunks/index8.mjs 5.85 kB 0%
chunks/index9.mjs 885.9 kB 0%
shared/create-nuxt.BSm0_9Hr.mjs 107 B 0%
shared/create-nuxt.jjur9XJH.mjs 43.55 kB 0%
shared/create-nuxt.BjhZEm2-.mjs 1.75 kB 0%
shared/create-nuxt.DnK9Crop.mjs 26.94 kB 0%

Copy link
Contributor

github-actions bot commented Mar 8, 2025

Bundle Stats β€” nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
55 5.29 MB β†’ 5.29 MB (+134 B) +0.00%
Changeset
File Ξ” Size
src/commands/init.ts πŸ“ˆ +91 B (+1.25%) 7.11 kB β†’ 7.2 kB
src/commands/module/add.ts πŸ“ˆ +43 B (+0.41%) 10.32 kB β†’ 10.37 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/init.mjs 663.56 kB β†’ 663.65 kB (+91 B) +0.01%
chunks/add2.mjs 12.21 kB β†’ 12.25 kB (+43 B) +0.34%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 210 B 0%
chunks/prompt.mjs 42.92 kB 0%
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 1.96 kB 0%
chunks/dev.mjs 7.48 kB 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.22 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.25 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/main.mjs 15.3 kB 0%
chunks/index2.mjs 915.2 kB 0%
chunks/dev2.mjs 70 kB 0%
chunks/index3.mjs 17.14 kB 0%
chunks/index4.mjs 71.98 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/search.mjs 45.83 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 134.23 kB 0%
chunks/index5.mjs 1.23 kB 0%
chunks/index6.mjs 5.85 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
chunks/index7.mjs 885.9 kB 0%
shared/nuxi.BKSvbvjM.mjs 76.15 kB 0%
shared/nuxi.DqkIr2yV.mjs 18.95 kB 0%
shared/nuxi.Bvkha4gC.mjs 804 B 0%
shared/nuxi.D7n12WIr.mjs 294 B 0%
shared/nuxi.BfmaxnpL.mjs 2.57 kB 0%
shared/nuxi.D2_bzAv0.mjs 1.54 kB 0%
shared/nuxi.BGsL6WwO.mjs 4.07 kB 0%
shared/nuxi.BSm0_9Hr.mjs 107 B 0%
shared/nuxi.BeSCWecd.mjs 836 B 0%
shared/nuxi._8J0PkaN.mjs 1.34 kB 0%
shared/nuxi.CoaHqGOR.mjs 14.64 kB 0%
shared/nuxi.BcEzdr5W.mjs 10.03 kB 0%
shared/nuxi.BjycWew7.mjs 2.02 MB 0%
shared/nuxi.E-ZsRS8r.mjs 943 B 0%
shared/nuxi.BjhZEm2-.mjs 1.75 kB 0%
shared/nuxi.CIIOD_vg.mjs 715 B 0%
shared/nuxi.Kph9bHCN.mjs 26.94 kB 0%
shared/nuxi.B8RZQP9m.mjs 123.47 kB 0%
shared/nuxi.D4vggcPe.mjs 5.7 kB 0%
shared/nuxi.JlPZHmu9.mjs 53.93 kB 0%
shared/nuxi.Do0aYBCO.mjs 5.46 kB 0%
shared/nuxi.jjur9XJH.mjs 43.55 kB 0%

Copy link
Contributor

github-actions bot commented Mar 8, 2025

Bundle Stats β€” nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
30 82.27 kB β†’ 82.4 kB (+134 B) +0.16%
Changeset
File Ξ” Size
home/runner/work/cli/cli/packages/nuxi/src/commands/init.ts πŸ“ˆ +91 B (+1.25%) 7.08 kB β†’ 7.17 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/module/add.ts πŸ“ˆ +43 B (+0.41%) 10.31 kB β†’ 10.35 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/init.mjs 7.45 kB β†’ 7.54 kB (+91 B) +1.19%
chunks/add2.mjs 10.31 kB β†’ 10.35 kB (+43 B) +0.41%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 224 B 0%
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 1.97 kB 0%
chunks/dev.mjs 7.43 kB 0%
chunks/devtools.mjs 763 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.22 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.25 kB 0%
chunks/dev2.mjs 8.16 kB 0%
chunks/search.mjs 2.94 kB 0%
shared/cli.CDrfLbqq.mjs 5.5 kB 0%
shared/cli.BMVuNG7k.mjs 804 B 0%
shared/cli.ApkskrXk.mjs 294 B 0%
shared/cli.D7GNsoFG.mjs 1.23 kB 0%
shared/cli.BSm0_9Hr.mjs 107 B 0%
shared/cli.BhrZatnq.mjs 836 B 0%
shared/cli.DlcAx0De.mjs 1.04 kB 0%
shared/cli.CCorTjsv.mjs 1.72 kB 0%
shared/cli.CCS3MFKI.mjs 78 B 0%
shared/cli.C935N1ss.mjs 687 B 0%

Copy link

pkg-pr-new bot commented Mar 8, 2025

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt@785
npm i https://pkg.pr.new/nuxi@785
npm i https://pkg.pr.new/@nuxt/cli@785

commit: b7d79f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant