Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): automatically add tunnel hostnames to vite allowedHosts #759

Merged
merged 3 commits into from
Mar 2, 2025

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#31184

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

this gets URLs from tunnels and automatically adds them to vite's allow-list for hosts

Copy link
Contributor

github-actions bot commented Mar 2, 2025

Bundle Stats β€” create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
50 5.68 MB β†’ 5.68 MB (+473 B) +0.01%
Changeset
File Ξ” Size
home/runner/work/cli/cli/packages/nuxi/src/utils/dev.ts πŸ“ˆ +358 B (+4.49%) 7.79 kB β†’ 8.14 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/dev.ts πŸ“ˆ +92 B (+1.22%) 7.39 kB β†’ 7.48 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/dev-child.ts πŸ“ˆ +23 B (+1.16%) 1.94 kB β†’ 1.96 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/dev2.mjs 69.61 kB β†’ 69.96 kB (+358 B) +0.50%
chunks/dev.mjs 7.39 kB β†’ 7.48 kB (+92 B) +1.22%
chunks/dev-child.mjs 1.94 kB β†’ 1.96 kB (+23 B) +1.16%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 1.05 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.22 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.25 kB 0%
chunks/prompt.mjs 42.92 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/kit.mjs 1.34 kB 0%
chunks/index2.mjs 923.65 kB 0%
chunks/index3.mjs 17.14 kB 0%
chunks/index4.mjs 71.98 kB 0%
chunks/add2.mjs 12.16 kB 0%
chunks/search.mjs 45.83 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 134.23 kB 0%
chunks/index5.mjs 1.23 kB 0%
chunks/index6.mjs 6.25 kB 0%
chunks/index7.mjs 50.51 kB 0%
chunks/index8.mjs 5.85 kB 0%
chunks/index9.mjs 885.9 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
shared/create-nuxt.ClcX4iYW.mjs 1.03 MB 0%
shared/create-nuxt.BwRJ02Rl.mjs 18.95 kB 0%
shared/create-nuxt.CZdviaDT.mjs 804 B 0%
shared/create-nuxt.6pUCJOe0.mjs 294 B 0%
shared/create-nuxt.CYZmidTa.mjs 3.9 kB 0%
shared/create-nuxt.BdgeZ66H.mjs 3.71 kB 0%
shared/create-nuxt.BSm0_9Hr.mjs 107 B 0%
shared/create-nuxt.C7qMsQG1.mjs 836 B 0%
shared/create-nuxt.nQGJK5sw.mjs 108.13 kB 0%
shared/create-nuxt.DgfCHDkt.mjs 14.63 kB 0%
shared/create-nuxt.H-PkQFRO.mjs 2.02 MB 0%
shared/create-nuxt.jjur9XJH.mjs 43.55 kB 0%
shared/create-nuxt.BjhZEm2-.mjs 1.75 kB 0%
shared/create-nuxt.Dw9uVtuI.mjs 2.51 kB 0%
shared/create-nuxt.DnK9Crop.mjs 26.94 kB 0%
shared/create-nuxt.CW5EAmkP.mjs 124.17 kB 0%

Copy link
Contributor

github-actions bot commented Mar 2, 2025

Bundle Stats β€” nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
30 80.62 kB β†’ 81.08 kB (+473 B) +0.57%
Changeset
File Ξ” Size
home/runner/work/cli/cli/packages/nuxi/src/utils/dev.ts πŸ“ˆ +358 B (+4.49%) 7.78 kB β†’ 8.13 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/dev.ts πŸ“ˆ +92 B (+1.22%) 7.34 kB β†’ 7.43 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/dev-child.ts πŸ“ˆ +23 B (+1.15%) 1.95 kB β†’ 1.97 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/dev2.mjs 7.78 kB β†’ 8.13 kB (+358 B) +4.49%
chunks/dev.mjs 7.34 kB β†’ 7.43 kB (+92 B) +1.22%
chunks/dev-child.mjs 1.95 kB β†’ 1.97 kB (+23 B) +1.15%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 224 B 0%
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/devtools.mjs 763 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/init.mjs 6.36 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.22 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.25 kB 0%
chunks/add2.mjs 10.3 kB 0%
chunks/search.mjs 2.94 kB 0%
shared/cli.DBd-hElG.mjs 5.5 kB 0%
shared/cli.UWk0bp-T.mjs 804 B 0%
shared/cli.bQkndgkC.mjs 294 B 0%
shared/cli.JXz_Mhkh.mjs 1.23 kB 0%
shared/cli.BSm0_9Hr.mjs 107 B 0%
shared/cli.CLioTKaN.mjs 836 B 0%
shared/cli.DlcAx0De.mjs 1.04 kB 0%
shared/cli.Bcns2ZtY.mjs 1.66 kB 0%
shared/cli.WDXJgBkr.mjs 78 B 0%
shared/cli.C935N1ss.mjs 687 B 0%

Copy link
Contributor

github-actions bot commented Mar 2, 2025

Bundle Stats β€” nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
55 5.52 MB β†’ 5.52 MB (+473 B) +0.01%
Changeset
File Ξ” Size
src/utils/dev.ts πŸ“ˆ +358 B (+4.49%) 7.79 kB β†’ 8.14 kB
src/commands/dev.ts πŸ“ˆ +92 B (+1.22%) 7.39 kB β†’ 7.48 kB
src/commands/dev-child.ts πŸ“ˆ +23 B (+1.16%) 1.94 kB β†’ 1.96 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/dev2.mjs 69.62 kB β†’ 69.97 kB (+358 B) +0.50%
chunks/dev.mjs 7.39 kB β†’ 7.48 kB (+92 B) +1.22%
chunks/dev-child.mjs 1.94 kB β†’ 1.96 kB (+23 B) +1.16%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 188 B 0%
chunks/prompt.mjs 42.92 kB 0%
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/init.mjs 668.33 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.22 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.25 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/main.mjs 15.3 kB 0%
chunks/index2.mjs 915.2 kB 0%
chunks/index3.mjs 17.14 kB 0%
chunks/index4.mjs 71.98 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/add2.mjs 12.16 kB 0%
chunks/search.mjs 45.83 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 134.23 kB 0%
chunks/index5.mjs 1.23 kB 0%
chunks/index6.mjs 5.85 kB 0%
chunks/index7.mjs 885.9 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
shared/nuxi.D5U3oSa9.mjs 76.07 kB 0%
shared/nuxi.DqkIr2yV.mjs 18.95 kB 0%
shared/nuxi.C0XOWnGm.mjs 804 B 0%
shared/nuxi.BSP3l5sz.mjs 294 B 0%
shared/nuxi.BCWDQGaq.mjs 2.57 kB 0%
shared/nuxi.D2_bzAv0.mjs 1.54 kB 0%
shared/nuxi.BZevXjF1.mjs 3.71 kB 0%
shared/nuxi.BSm0_9Hr.mjs 107 B 0%
shared/nuxi.JWBOk7pn.mjs 836 B 0%
shared/nuxi.CdLKTWzs.mjs 1.34 kB 0%
shared/nuxi.HiGHWrR5.mjs 14.63 kB 0%
shared/nuxi.2cDPfPXe.mjs 284.41 kB 0%
shared/nuxi.BxQQOHdn.mjs 2.02 MB 0%
shared/nuxi.E-ZsRS8r.mjs 943 B 0%
shared/nuxi.BjhZEm2-.mjs 1.75 kB 0%
shared/nuxi.BHKYoZj3.mjs 124.17 kB 0%
shared/nuxi.Kph9bHCN.mjs 26.94 kB 0%
shared/nuxi.9fSIe8_G.mjs 2.51 kB 0%
shared/nuxi.D4vggcPe.mjs 5.7 kB 0%
shared/nuxi.Bwkhf2s-.mjs 10.22 kB 0%
shared/nuxi.Do0aYBCO.mjs 5.46 kB 0%
shared/nuxi.jjur9XJH.mjs 43.55 kB 0%

Copy link

pkg-pr-new bot commented Mar 2, 2025

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt@759
npm i https://pkg.pr.new/nuxi@759
npm i https://pkg.pr.new/@nuxt/cli@759

commit: ec36e03

@danielroe danielroe merged commit e0427ad into main Mar 2, 2025
11 checks passed
@danielroe danielroe deleted the fix/tunnel branch March 2, 2025 23:24
@github-actions github-actions bot mentioned this pull request Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocked Request when tunnelling with v3.15.4
1 participant