Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxi) : set correct filetype in module template #693

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

djrasmusp
Copy link
Contributor

@djrasmusp djrasmusp commented Jan 20, 2025

πŸ”— Linked issue

resolves #692

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

change filetype from '.vue' to '.ts' in the module template.

- change filetype from '.vue' to '.ts'
@djrasmusp djrasmusp requested a review from danielroe as a code owner January 20, 2025 18:48
Copy link

pkg-pr-new bot commented Jan 20, 2025

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt-app@693
npm i https://pkg.pr.new/nuxi@693
npm i https://pkg.pr.new/@nuxt/cli@693

commit: e78175b

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@d769943). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/utils/templates/module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main    #693   +/-   ##
======================================
  Coverage        ?   3.31%           
======================================
  Files           ?      65           
  Lines           ?    3136           
  Branches        ?      49           
======================================
  Hits            ?     104           
  Misses          ?    2997           
  Partials        ?      35           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe merged commit 9592f01 into nuxt:main Jan 20, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug : Command 'add module' creates module file with wrong filetype
3 participants