Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): add --dedupe option #691

Merged
merged 3 commits into from
Jan 20, 2025
Merged

feat(upgrade): add --dedupe option #691

merged 3 commits into from
Jan 20, 2025

Conversation

OrbisK
Copy link
Contributor

@OrbisK OrbisK commented Jan 20, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Recreated #573 due to unrelated git histories (?)

Use nypm to dedupe or force dependencies.

TODO:

  • test with pkg.pr.new

@OrbisK OrbisK requested a review from danielroe as a code owner January 20, 2025 12:00
Copy link

pkg-pr-new bot commented Jan 20, 2025

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt-app@691
npm i https://pkg.pr.new/nuxi@691
npm i https://pkg.pr.new/@nuxt/cli@691

commit: 0629e8a

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@2bacc17). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/commands/upgrade.ts 0.00% 36 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main    #691   +/-   ##
======================================
  Coverage        ?   3.31%           
======================================
  Files           ?      65           
  Lines           ?    3136           
  Branches        ?      49           
======================================
  Hits            ?     104           
  Misses          ?    2997           
  Partials        ?      35           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’ͺ

@danielroe danielroe merged commit d769943 into nuxt:main Jan 20, 2025
8 of 9 checks passed
@OrbisK
Copy link
Contributor Author

OrbisK commented Jan 20, 2025

I think this may be updated for the following nuxt release notes, if released πŸ˜„

As usual, our recommendation for upgrading is to run:

npx nuxi@latest upgrade --force
This will refresh your lockfile as well, and ensures that you pull in updates from other dependencies that Nuxt relies on, particularly in the unjs ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants