Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): prepend baseURL for vite hmr ws upgrade #370

Merged
merged 3 commits into from Mar 20, 2024
Merged

fix(dev): prepend baseURL for vite hmr ws upgrade #370

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b24462f
fix: consider `baseURL` for ws upgrade
antfu Mar 20, 2024
1e16d5f
[autofix.ci] apply automated fixes
autofix-ci[bot] Mar 20, 2024
6373c5f
chore: update
antfu Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/utils/dev.ts
View file
Open in desktop
Expand Up @@ -244,14 +244,15 @@ class NuxtDevServer extends EventEmitter {
this.listener.server.on(
'upgrade',
async (req: any, socket: any, head: any) => {
if (
req.url.startsWith(
this._currentNuxt?.options.app.buildAssetsDir /* /_nuxt/ */,
)
) {
const nuxt = this._currentNuxt
if (!nuxt) return
const viteHmrPath = (
nuxt.options.app.baseURL + nuxt.options.app.buildAssetsDir
).replace(/\/\//g, '/')
antfu marked this conversation as resolved.
Show resolved Hide resolved
if (req.url.startsWith(viteHmrPath)) {
return // Skip for Vite HMR
}
await this._currentNuxt?.server.upgrade(req, socket, head)
await nuxt.server.upgrade(req, socket, head)
pi0 marked this conversation as resolved.
Show resolved Hide resolved
},
)
}
Expand Down