Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): sync current route for the same component #464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johannschopplich
Copy link

@johannschopplich johannschopplich commented Sep 21, 2023

Hi there!

I finally migrated my Vue Ionic app to Nuxt. Most of the Vite configuration like setting up auto-imports etc. can be thrown away. Nuxt does so much out of the box, even in non-SSR mode. Thanks a lot for Nuxt as well as this plugin! Finally, I can use suspense routes in the Ionic setup. A dream come true.

But I ran into a problem: Navigating between routes (not using any tabs at all) using different page components doesn't update the route state. I investigate the issue and found:

if (to.matched[0]?.components?.default === from.matched[0]?.components?.default) {}

Why do you guard the route sync to the same component only? I'm not sure if I follow. Can't we sync the current route no matter what? What do you think? It fixed my stale route state issue.

No minimal reproducible example provided. If you need one, please drop me a line.

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for friendly-lamington-fb5690 canceled.

Name Link
🔨 Latest commit 43b118f
🔍 Latest deploy log https://app.netlify.com/sites/friendly-lamington-fb5690/deploys/650bfdd861e1760008a1bf3b

@danielroe danielroe self-requested a review as a code owner May 19, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant