Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying theme-color according to the current dark/light mode configuration.
Implementing this outside of
color-mode-module
has the following caveats:<meta name="theme-color" content="...">
tags in the raw HTML. If we always used the system color mode, we could use themedia="..."
attribute, but this does not apply to our case.theme-color
meta tag.storageKey
, the developer also have to make sure the custom script always uses the same storage key.Making the theme-color support built-in solves all of the problems above.
Note: dynamic
theme-color
is out of scope, since there would be no elegant way to specify this. The user can still implement their owntheme-color
setting mechanism despite the caveats.