Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): support Nitro useDatabase() #15

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(db): support Nitro useDatabase() #15

wants to merge 9 commits into from

Conversation

Atinux
Copy link
Contributor

@Atinux Atinux commented Mar 7, 2024

Resolves #2

Waiting for unjs/nitro#2228 to be released.

This will allow to use useDatabase() with no configuration 🚀

@Atinux Atinux added upstream enhancement New feature or request labels Mar 7, 2024
Copy link

cloudflare-pages bot commented Mar 9, 2024

Deploying nuxthub-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 555880a
Status: ✅  Deploy successful!
Preview URL: https://aa51021a.nuxthub-module.pages.dev
Branch Preview URL: https://feat-nitro-db.nuxthub-module.pages.dev

View logs

@Atinux Atinux marked this pull request as ready for review March 9, 2024 16:48
@cpreston321
Copy link

Any update on this? @Atinux ?

@Atinux
Copy link
Contributor Author

Atinux commented Apr 10, 2024

Actually I need to change it @cpreston321 to only enable it if nitro.experimental.database is set to true.

After discussing with @pi0, NuxtHub should not set experimental feature on behalf of the user.

@Sandros94
Copy link
Contributor

After discussing with @pi0, NuxtHub should not set experimental feature on behalf of the user.

I also agree.

Since useDatabase() is based on db0 (that quite early in development), would this mean that this feature will be postponed till a later Nitro 3.x version?

@pi0
Copy link

pi0 commented Apr 11, 2024

useDatabase() will be eventually enabled out of the box for Nitro v2 as well.

In the meantime I appreciate any feedback from direct db0 integration which can help to stabilize and discover any issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Nitro database to use hubDatabase()
4 participants