Update Request.php #1941
Open
Update Request.php #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix X-Forwarded-* placeholders
We have a Netscaler as reverse proxy to publish syspass in docker.
The client IP wasn't read correctly by syspass, if someone inside the company log in with the wrong password more than 10 times all the users have been blocked.
We noticed that by changing the line to $xForwarded = $this->headers->get('X_FORWARDED_FOR'); the header set by the Netscaler is correctly read, and on the SysPass side, the addresses of the PCs making the request are recognized, not those of the reverse proxy. This allows us to avoid blocking the entire company and to have more accurate logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix X-Forwarded-* placeholders