Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme based on Github Theme #1727

Open
wants to merge 13 commits into
base: v3.2
Choose a base branch
from
Open

Conversation

ThigSchuch
Copy link

@ThigSchuch ThigSchuch commented Jul 14, 2021

Dark theme using mostly the palette of Github
#0D1117, #161B22 and #C9C9C9

image

image

image

image

image

@nuxsmin
Copy link
Owner

nuxsmin commented Sep 18, 2021

Hello,

Thanks a lot for your contribution!!

Could you make the PR to the correct release branch?. master branch is only used for the current stable release.

Regards

@ThigSchuch
Copy link
Author

I saw that you commented to @alek10c about .SCSS files.
I did this theme copying your whole material-blue folder and changing every single color inside .CSS files.
Any problem? 😅

@nuxsmin nuxsmin changed the base branch from master to v3.2 September 25, 2021 08:02
@nuxsmin
Copy link
Owner

nuxsmin commented Sep 25, 2021

I saw that you commented to @alek10c about .SCSS files.
I did this theme copying your whole material-blue folder and changing every single color inside .CSS files.
Any problem? sweat_smile

Hello,

it would be useful to use the .scss files in order to make changes faster, since it will allow to compile all the needed .css files and make it more maintainable.

Regards.

@adocampo
Copy link

I know this PR isn't merged yet, but I wanted to try it anyway, so I downloaded the fork, and copied the material-dark directory and selected the theme on the syspass settings.
Logon screen applies the theme, but the entire application sticks to default theme. Am I missing something, is there any ETA about this PR? Our eyes will be thankful about this :P

@nuxsmin
Copy link
Owner

nuxsmin commented May 25, 2022

I know this PR isn't merged yet, but I wanted to try it anyway, so I downloaded the fork, and copied the material-dark directory and selected the theme on the syspass settings. Logon screen applies the theme, but the entire application sticks to default theme. Am I missing something, is there any ETA about this PR? Our eyes will be thankful about this :P

Hello @adocampo !

Your behavior could be related to the user preferences, if you set them before, the theme set takes precedence over the system one.

This PR will be merged shortly. I've been doing many code tasks and hopefully I'd be able to take some time for this :)

@adocampo
Copy link

Hola @nuxsmin !

I saw earlier today there was a newer version and I thought Dark theme would be on there… I guess we'll need to wait a bit longer, but I'm glad to see it will be release soon :)

I changed the theme both in server settings (config.xml) and inside the GUI on global settings. I didn't notice I could set this per user under user preferences, and it seems that changing the theme on user's preferences it works!. \o/

Perhaps this is not the best place to talk about this, but I saw two things perhaps anyone noticed yet:

  • Global settings don't honor material-dark theme: just logon page appears black, but the entire site remains on the default theme, at least on already existing users
  • Logon page under chromium-based browsers, if we use any browser password manager, it seems to break the css (both in default and dark theme
    imagen
    but clearing the password shows the logon form as expected
    imagen
    If you take a close look, Firefox has the same issue, but recovers itself and can show the proper CSS almost immediately.
    Peek 26-05-2022 00-46

Anyway, thank you both for your work! 👍🏻

@eduardomozart
Copy link

If you're using the Authenticator plugin, you need to apply the PR sysPass/plugin-Authenticator#48 otherwise it will not show up the form to type in the Authenticator code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants