-
-
Notifications
You must be signed in to change notification settings - Fork 118
Improve default font, mouse, and line thickness scaling on macOS #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for raising PR!
I think this scaling difference comes from the dpi.
We can use below Python API to change DPI automatically.
https://docs.blender.org/api/current/bpy.types.PreferencesSystem.html#bpy.types.PreferencesSystem.dpi
https://docs.blender.org/api/current/bpy.types.PreferencesSystem.html#bpy.types.PreferencesSystem.pixel_size
What do you think?
default=int(bpy.context.preferences.ui_styles[0].widget.points), | ||
default=int( | ||
bpy.context.preferences.ui_styles[0].widget.points | ||
* (5 if is_macos else 1)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think changing font_size
is not good idea because this configuration should be constraint in user side.
Instead, we can change the scale before feeding the font_size to API.
This is same for others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi nutti, thank you for your suggestion! My quarter is about to end, and I will fix this the next few days!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JingRyu
Thank you. It's ok to me.
If you have any help, please let me know.
Purpose of the pull request
Improve default display scaling on macOS
Description about the pull request
Adjust default
font_size
,mouse_size
, andline_thickness
for better visibility on macOS Retina displays.Additional comments [Optional]
I’m happy to contribute for macOS users. Thank you for maintaining this project!