Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate nu-testbin binary #12839

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IanManske
Copy link
Member

Description

This PR removes the --testbin flag on the main nushell binary and moves this functionality to the new nu-testbin binary. This binary was added to the workspace and marked as publish = false in its Cargo.toml. After this, we will no longer ship testing code to our users, and the removal of the --testbin flag will make the CLI slightly less cluttered.

User-Facing Changes

"Breaking" change: removes the --testbin flag from the main nushell binary.

@IanManske IanManske added the pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes label May 12, 2024
@IanManske
Copy link
Member Author

IanManske commented May 12, 2024

Still some open questions:

  • Where should the binary go? I put it in testbin/ at the workspace root.
  • The nu-testbin binary inherits/shares dependencies with the main binary. This isn't a huge issue, but it means that compiling nu-testbin might take longer than necessary. Some Cargo.toml fanegaling might be able to fix this.
  • Binaries are only built in certain cases. E.g., cargo test -p <crate> does not build nu or nu-testbin. So, this can cause tests to fail unless cargo test --workspace or cargo b is run beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:breaking-change This PR implies a change affecting users and has to be noted in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant