Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/release: Make tar archive reproducible #12705

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cgwalters
Copy link

This is just a general good practice, but I hit a weird issue where trying to unpack this tarball in a github action failed because we changed ownership to the runner when run as root.

(I didn't test this locally, sorry)

This is just a general good practice, but I hit a weird issue
where trying to unpack this tarball in a github action failed
because we changed ownership to the runner when run as root.

Signed-off-by: Colin Walters <[email protected]>
@fdncred
Copy link
Collaborator

fdncred commented Apr 30, 2024

That whole --pax-option parameter looks a little suspect especially since the docs say --format=gnu would do the same thing. It also seems to require gnu tar of a certain version. I'm not sure what flavor is used in our CI.

This would all need to be tested first, of course.

@fdncred fdncred marked this pull request as draft April 30, 2024 14:25
@devyn
Copy link
Contributor

devyn commented May 2, 2024

I think it's very unlikely that this will work on macOS, because the tar there is very limited. It doesn't have most of these options, not even --owner / --group (which would fix your issue)

I suppose we could make sure we're using GNU tar on macOS somehow too. Alternatively, we could switch to using zip files on macOS I guess - for our needs that would be a perfectly okay format.

@cgwalters
Copy link
Author

cgwalters commented May 2, 2024

The other alternative to be fully cross-platform is to use tar-rs; it's what I did in cargo vendor-filterer.

@devyn devyn added the build-package Everything concerning the CI build process and packaging of nushell label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-package Everything concerning the CI build process and packaging of nushell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants