-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AY1920S1-CS2113T-F14-3] Contact List Pro #95
base: master
Are you sure you want to change the base?
[AY1920S1-CS2113T-F14-3] Contact List Pro #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pay attention to if .. else .. format
private static final String outOfBounds_Text = "Index is out of Bounds!"; | ||
private static final String anomaly_Text = "Anomaly Detected"; | ||
private static final String emptyList_Text = "List is empty"; | ||
private static final String timeClash_Text = "Time Clash Detected"; | ||
private static final String wrongFormat_Text = "Wrong Format Detected"; | ||
private static final String wrongPriority_Text = "You've entered wrong format of priority"; | ||
private static final String subTask_Text = "Meetings do not support Subtasks"; | ||
public static final String wrongTaskType_Text = "Only meeting or assignment tag are accepted"; | ||
public static final String emptyDescription_Text = "You haven't included the description of you task"; | ||
public static final String emptyDate_Text = "You haven't included the date of your task"; | ||
public static final String emptyTaskType_Text = "You haven't specified the type of your task: assignment or meeting"; | ||
public static final String writeError_Text = "Error in writing file, cancelling write process..."; | ||
public static final String wrongIndexFormat_Text = "The index you've enter is in the wrong format"; | ||
public static final String wrongTimeFormat_Text = "You've entered an invalid time format"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use cap for constant variables
* @param type type of exception detected | ||
*/ | ||
public RoomShareException(ExceptionType type){ | ||
switch(type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good use of enum, keep it up !
/** | ||
* This class checks if there are clashes in timings for events | ||
*/ | ||
public class CheckAnomaly { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class name should be a noun
src/main/java/Operations/Parser.java
Outdated
* @param by Input String containing the date information. | ||
* @return A Date object containing the appropriately formatted date. | ||
*/ | ||
public Date formatDateCustom_1(String by) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more descriptive function name.
int minutes = Integer.parseInt(time[1]); | ||
date.setHours(hours); | ||
date.setMinutes(minutes); | ||
if (day.toLowerCase().equals("tomorrow") || day.toLowerCase().equals("tmr")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no magic string
|
||
import CustomExceptions.RoomShareException; | ||
import Enums.RecurrenceScheduleType; | ||
import Model_Classes.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not import*, only import used classes
* @param isEdited boolean variable describing if the task list has been edited in anyway | ||
* @return | ||
*/ | ||
private boolean dateHasPassedOthers(String currentTime, Task check, boolean isEdited) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hasDatePassedOthers
String[] descriptionArray2 = descriptionArray[1].trim().split("\\)"); | ||
description = descriptionArray2[0].trim(); | ||
} | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
violation of coding standard
unit = TimeUnit.unDefined; | ||
} | ||
} | ||
else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
violation
add function to update tasks
update my code
add function to create and write log files
add logs folder
add auto generate logs folder
update cide base
added tests
� Conflicts: � src/main/java/Model_Classes/Task.java
update my code
updated tests for taskcreator
Added CheckAnomalyTest & test.txt
getting test.txt data set
Merge pull request #230 from tyeryan/master
bugfixes on logic and ui
updated 10/11
Reordered help list to tally with quickstart guide in UG
style enforcement, bug fix on CheckAnomaly
improved accuracy of descriptions in help
updated 11/11
Updated for checkstyle violations
added UGDG
No description provided.