Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the runner to swallow its threads error #641

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

tucksaun
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
Fixed tickets #609

This should fix #609.
Maybe not directly but it should make the initial error bubble up allowing the user to fix it or report it properly instead of having an "Unable to find data for" error.

For example:


    0/2205 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   0%

In Runner.php line 163:

  The command "'/opt/homebrew/Cellar/[email protected]/8.1.17/bin/php' '[...]/vendor/bin/phpinsights' 'internal:processors' 'thread-1-fd43f7fb701672bfec0768e9b3d9828c'" failed.

  Exit Code: 255(Unknown error)

  Working directory: [...]

  Output:
  ================

  Fatal error: Allowed memory size of 33554432 bytes exhausted (tried to allocate 135168 bytes) in [...]/vendor-bin/phpinsights/vendor/squizlabs/php_codesniffer/src/Tokenizers/PHP.php on line 2329


  Error Output:
  ================
  PHP Fatal error:  Allowed memory size of 33554432 bytes exhausted (tried to allocate 135168 bytes) in [...]/vendor-bin/phpinsights/vendor/squizlabs/php_codesniffer/src/Tokenizers/PHP.php on line 2329


analyse [-c|--config-path [CONFIG-PATH]] [-s|--summary] [--min-quality [MIN-QUALITY]] [--min-complexity [MIN-COMPLEXITY]] [--min-architecture [MIN-ARCHITECTURE]] [--min-style [MIN-STYLE]] [--disable-security-check] [--format FORMAT] [--composer [COMPOSER]] [--fix] [--flush-cache] [--] [<paths>...]

make: *** [phpinsights] Error 1

This should fix nunomaduro#609, or at least make the initial error bubble up allowing the user to fix it or report it properly
@cmgmyr cmgmyr force-pushed the fix-runner-swallow-thread-errors branch from 22aaee0 to 77ba1c5 Compare September 28, 2023 03:44
@cmgmyr
Copy link
Collaborator

cmgmyr commented Sep 28, 2023

Thanks!

@cmgmyr cmgmyr merged commit 3785369 into nunomaduro:master Sep 28, 2023
43 checks passed
@tucksaun tucksaun deleted the fix-runner-swallow-thread-errors branch September 28, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to find data for
2 participants