Enable legacyCorruptedStateExceptionsPolicy

[jnm2]

Fixes #336.

Also, in order to fix the intermittent test run hangs investigated at nunit/nunit#3295, at least one of the following things must happen:

• This PR gets merged (that was easy, let's go with this one for now 😅)

• Microsoft ports the .NET Core fix to .NET Framework 4.7 and 4.8 to fix the race condition that causes stack traces to throw AccessViolationException

• NUnit Framework drops support for partial trust (see comment in this PR and Reproducible hang with no user code when shutting down threads nunit#3295)

• NUnit Framework implements a watchdog thread to notice the highly bizarre situation set up by the console's current app.config where the console process isn't killed but the NUnit framework test worker thread is killed (see comment in this PR and Reproducible hang with no user code when shutting down threads nunit#3295)

[ChrisMaddock]

I agree with your conclusions here - I'd like to hear @rprouse opinion before we merge though. 🙂

[jnm2]

Awesome! I fixed typos. Guess I was up too late.

[rprouse]

This looks good. I know some of our users still have partial trust issues tests, so dropping support for it isn't an option right now.

[KirillOsenkov]

Hi @jnm2 would you happen to remember a link to

Microsoft ports the .NET Core fix to .NET Framework 4.7 and 4.8 to fix the race condition that causes stack traces to throw AccessViolationException

We're hitting an AccessViolationException here:
microsoft/vstest#3543 (comment)

and I feel like under some circumstances Assembly.LoadFrom() on .NET Framework can throw AccessViolationException but I can find almost no information about it anywhere, grasping at the straws here

[jnm2]

@KirillOsenkov Yes, see nunit/nunit#3295 (comment)

[KirillOsenkov]

Nice, thanks! Looks like it's a different one from ours, ours is in Assembly.LoadFrom(). Also the stack trace one was (fortunately!) fixed for .NET Framework (in fact I think I remember how we fixed it a few years back).

[jnm2]

It does look different. Not sure what to make of this one. Good luck!