Skip to content

fix: Removing existing finalizer for monovertex and controller #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chandankumar4
Copy link
Contributor

Fixes #704

Modifications

This change will fix the issue regarding finalizer left on resource after deletion.

  • Removing existing finalizer for monovertex and controller

Verification

  • Verified on local k8s

Backward incompatibilities

@chandankumar4 chandankumar4 marked this pull request as ready for review April 27, 2025 19:57
Copy link
Collaborator

@juliev0 juliev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will wait until you look into the CI failure, thanks

Copy link
Collaborator

@juliev0 juliev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will wait until you look into the CI failure, thanks

Copy link
Collaborator

@juliev0 juliev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I noticed that your test failure also happened here for a separate PR: https://github.com/numaproj/numaplane/actions/runs/14697017565/job/41240051750?pr=727

let me look into that failure

@juliev0
Copy link
Collaborator

juliev0 commented Apr 27, 2025

okay, I noticed that your test failure also happened here for a separate PR: https://github.com/numaproj/numaplane/actions/runs/14697017565/job/41240051750?pr=727

let me look into that failure

If you download at the MonoVertexRollout from the CI, it seems that for some reason the new MonoVertexRollout is created before the previous MonoVertexRollout has actually been deleted. (You can tell because the progressiveStatus from the old one is still showing.) It's pretty weird because the test already checked that the MonoVertexRollout was no longer there here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move/modify check for dependent resources on deletion
2 participants