Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error handling and grace shutdown during udf failures #2406

Merged
merged 9 commits into from
Feb 20, 2025
Merged

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Feb 19, 2025

No description provided.

Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 82.80840% with 131 lines in your changes missing coverage. Please review.

Project coverage is 71.14%. Comparing base (01cc33d) to head (683bd8b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/numaflow-core/src/mapper/map.rs 83.70% 37 Missing ⚠️
...numaflow-core/src/pipeline/isb/jetstream/reader.rs 85.84% 15 Missing ⚠️
rust/numaflow-core/src/source.rs 75.80% 15 Missing ⚠️
...aflow-core/src/pipeline/forwarder/map_forwarder.rs 62.06% 11 Missing ⚠️
rust/numaflow-core/src/monovertex/forwarder.rs 67.85% 9 Missing ⚠️
...flow-core/src/pipeline/forwarder/sink_forwarder.rs 59.09% 9 Missing ⚠️
...ow-core/src/pipeline/forwarder/source_forwarder.rs 68.96% 9 Missing ⚠️
...numaflow-core/src/pipeline/isb/jetstream/writer.rs 84.09% 7 Missing ⚠️
rust/numaflow-core/src/lib.rs 0.00% 6 Missing ⚠️
rust/numaflow-core/src/sink.rs 86.84% 5 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2406      +/-   ##
==========================================
+ Coverage   71.08%   71.14%   +0.06%     
==========================================
  Files         368      368              
  Lines       53321    53558     +237     
==========================================
+ Hits        37903    38106     +203     
- Misses      14346    14373      +27     
- Partials     1072     1079       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigith vigith changed the title chore: fix error handling and grace shutdown during udf failures fix: error handling and grace shutdown during udf failures Feb 19, 2025
@yhl25 yhl25 marked this pull request as ready for review February 20, 2025 04:53
@yhl25 yhl25 requested review from whynowy and vigith as code owners February 20, 2025 04:53
@vigith vigith enabled auto-merge (squash) February 20, 2025 04:53
@vigith vigith merged commit ae6c2a6 into main Feb 20, 2025
28 checks passed
@vigith vigith deleted the udf-failures branch February 20, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants